fix(print): Language set in document should have higher precedence #20336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajshetty3416
requested review from
a team and
shariquerik
and removed request for
a team
surajshetty3416
added
backport version-13-hotfix
backport version-14-hotfix
This was referenced Mar 14, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
# [14.29.0](v14.28.2...v14.29.0) (2023-03-21) ### Bug Fixes * allow 5 column layout in doctype form ([7eb3bb4](7eb3bb4)) * Allow card actions (adding/dragging) if access to reference doctype ([bc5b362](bc5b362)) * Check perms on Kanban Column actions ([efa74bb](efa74bb)) * Check Reference Doctype perms & control indicator change ([c2fe3b0](c2fe3b0)) * clear contacts cache (backport [#20397](#20397)) ([#20406](#20406)) ([1905241](1905241)) * **Database:** clear background jobs and realtime logs on rollback ([#20236](#20236)) ([#20417](#20417)) ([750059b](750059b)) * Dispatch `update_order` always. Handle perm-wise action in backend ([e5c5cdb](e5c5cdb)) * handle image extraction while editing comment ([00c5f32](00c5f32)) * Hide Menu if empty & render columns without state change ([a9b5f04](a9b5f04)) * hide My Workspace sidebar section if empty in edit mode ([b51dd18](b51dd18)) * Hide Sort Selector in Kanban ([13be928](13be928)) * Kanban Board Menu Items Accessibility via perms ([4ffc7a5](4ffc7a5)) * **meta:** get_permitted_fields with no field-columns (backport [#20401](#20401)) ([#20405](#20405)) ([644c6c8](644c6c8)) * **patch:** move desk prop patch to post model sync ([#20361](#20361)) ([#20362](#20362)) ([661820a](661820a)) * **print:** Language set in document should have higher precedence (backport [#20336](#20336)) ([#20338](#20338)) ([a27178d](a27178d)) * server method to return evaluated dict of perms for a document ([d1446b8](d1446b8)) * Set link title in PDF ([716db05](716db05)) * sidebar becomes unhidden while removing skeleton ([71ac099](71ac099)) * skip InReadOnlyMode in error snapshots ([#20358](#20358)) ([#20359](#20359)) ([eb14fe1](eb14fe1)) * treat Phone as Data on list view ([06395dd](06395dd)) * **workspace:** Setup Dynamic Link if value exists ([b393d5b](b393d5b)) ### Features * clear integration log request logs ([#20373](#20373)) ([#20374](#20374)) ([4c48f55](4c48f55)) * configurable rounding methods (v14 port) ([#20330](#20330)) ([0d60385](0d60385)), closes [#20299](#20299) * **minor:** log datetime in worker log ([#20414](#20414)) ([#20418](#20418)) ([bfda74d](bfda74d)) ### Performance Improvements * Dont update list view data if list view not active ([#20396](#20396)) ([#20420](#20420)) ([3a6e307](3a6e307)) * rebuild website search index in background (backport [#17974](#17974)) ([#20335](#20335)) ([c1b0210](c1b0210))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
## [13.51.2](v13.51.1...v13.51.2) (2023-03-21) ### Bug Fixes * **Database:** clear background jobs and realtime logs on rollback ([#20236](#20236)) ([#20416](#20416)) ([f4f399e](f4f399e)) * **meta:** get_permitted_fields with no field-columns (backport [#20401](#20401)) ([#20404](#20404)) ([d2be9d7](d2be9d7)) * **print:** Language set in document should have higher precedence (backport [#20336](#20336)) ([#20337](#20337)) ([2a84075](2a84075)) ### Performance Improvements * Dont update list view data if list view not active ([#20396](#20396)) ([#20419](#20419)) ([85cd2d2](85cd2d2))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The system used to select "Default Print Language" set in print format even though language was set in document.
Fix:
Language set in document should have higher precedence than "Default Print Language" set in print format.