Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear integration log request logs #20373

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Mar 17, 2023

No description provided.

THese are basically logs of requests and shouldn't stay forever.
These doctypes were added to log settings later.
@ankush ankush requested review from a team and shariquerik and removed request for a team March 17, 2023 07:35
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #20373 (71d7f28) into develop (f2f7d43) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20373      +/-   ##
===========================================
+ Coverage    63.85%   63.89%   +0.03%     
===========================================
  Files          757      757              
  Lines        68623    68628       +5     
  Branches      6187     6187              
===========================================
+ Hits         43821    43847      +26     
+ Misses       21298    21273      -25     
- Partials      3504     3508       +4     
Flag Coverage Δ
server 68.73% <100.00%> (+0.01%) ⬆️
server-ui 31.69% <0.00%> (-0.02%) ⬇️
ui-tests 51.88% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush removed the add-test-cases Add test case to validate fix or enhancement label Mar 17, 2023
@ankush ankush merged this pull request into frappe:develop Mar 17, 2023
@ankush ankush deleted the integration_log_request_clear branch March 17, 2023 09:04
@ankush ankush added the backport version-14-hotfix backport to version 14 label Mar 17, 2023
ankush added a commit that referenced this pull request Mar 17, 2023
* fix: integration request should be cleared

THese are basically logs of requests and shouldn't stay forever.

* fix(UX): show retention policy message on sidebar

These doctypes were added to log settings later.
ankush added a commit that referenced this pull request Mar 17, 2023
* fix: integration request should be cleared

THese are basically logs of requests and shouldn't stay forever.

* fix(UX): show retention policy message on sidebar

These doctypes were added to log settings later.

(cherry picked from commit af0c5d0499f20d0c3bbacdb3d13c6a23846e188f)
ankush added a commit that referenced this pull request Mar 17, 2023
* fix: integration request should be cleared

THese are basically logs of requests and shouldn't stay forever.

* fix(UX): show retention policy message on sidebar

These doctypes were added to log settings later.

(cherry picked from commit af0c5d0499f20d0c3bbacdb3d13c6a23846e188f)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Mar 21, 2023
# [14.29.0](v14.28.2...v14.29.0) (2023-03-21)

### Bug Fixes

* allow 5 column layout in doctype form ([7eb3bb4](7eb3bb4))
* Allow card actions (adding/dragging) if access to reference doctype ([bc5b362](bc5b362))
* Check perms on Kanban Column actions ([efa74bb](efa74bb))
* Check Reference Doctype perms & control indicator change ([c2fe3b0](c2fe3b0))
* clear contacts cache (backport [#20397](#20397)) ([#20406](#20406)) ([1905241](1905241))
* **Database:** clear background jobs and realtime logs on rollback ([#20236](#20236)) ([#20417](#20417)) ([750059b](750059b))
* Dispatch `update_order` always. Handle perm-wise action in backend ([e5c5cdb](e5c5cdb))
* handle image extraction while editing comment ([00c5f32](00c5f32))
* Hide Menu if empty & render columns without state change ([a9b5f04](a9b5f04))
* hide My Workspace sidebar section if empty in edit mode ([b51dd18](b51dd18))
* Hide Sort Selector in Kanban ([13be928](13be928))
* Kanban Board Menu Items Accessibility via perms ([4ffc7a5](4ffc7a5))
* **meta:** get_permitted_fields with no field-columns (backport [#20401](#20401)) ([#20405](#20405)) ([644c6c8](644c6c8))
* **patch:** move desk prop patch to post model sync ([#20361](#20361)) ([#20362](#20362)) ([661820a](661820a))
* **print:** Language set in document should have higher precedence (backport [#20336](#20336)) ([#20338](#20338)) ([a27178d](a27178d))
* server method to return evaluated dict of perms for a document ([d1446b8](d1446b8))
* Set link title in PDF ([716db05](716db05))
* sidebar becomes unhidden while removing skeleton ([71ac099](71ac099))
* skip InReadOnlyMode in error snapshots ([#20358](#20358)) ([#20359](#20359)) ([eb14fe1](eb14fe1))
* treat Phone as Data on list view ([06395dd](06395dd))
* **workspace:** Setup Dynamic Link if value exists ([b393d5b](b393d5b))

### Features

* clear integration log request logs ([#20373](#20373)) ([#20374](#20374)) ([4c48f55](4c48f55))
* configurable rounding methods (v14 port) ([#20330](#20330)) ([0d60385](0d60385)), closes [#20299](#20299)
* **minor:** log datetime in worker log  ([#20414](#20414)) ([#20418](#20418)) ([bfda74d](bfda74d))

### Performance Improvements

* Dont update list view data if list view not active ([#20396](#20396)) ([#20420](#20420)) ([3a6e307](3a6e307))
* rebuild website search index in background (backport [#17974](#17974)) ([#20335](#20335)) ([c1b0210](c1b0210))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant