Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: rebuild website search index in background (backport #17974) #20335

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 14, 2023

This is an automatic backport of pull request #17974 done by Mergify.
Cherry-pick of fbee80f has failed:

On branch mergify/bp/version-14-hotfix/pr-17974
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit fbee80f734.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/migrate.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ui-tests.yml
	both modified:   frappe/utils/background_jobs.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* perf: rebuild website search index in background

* refactor: allow enqueueing jobs during migrate

This was added a long time ago to handle missing redis during migrate.
It is not the case right now as redis HAS to be availabe during
migration.

ref: #2988

* ci: pass correct build type

* chore: warn about redis unavailability

(cherry picked from commit fbee80f)

# Conflicts:
#	.github/workflows/ui-tests.yml
#	frappe/utils/background_jobs.py
@mergify mergify bot requested a review from a team as a code owner March 14, 2023 09:09
@mergify mergify bot requested review from phot0n and removed request for a team March 14, 2023 09:09
@mergify mergify bot added the conflicts label Mar 14, 2023
@mergify mergify bot assigned ankush Mar 14, 2023
@ankush ankush added squash and removed conflicts labels Mar 14, 2023
@ankush ankush merged commit c1b0210 into version-14-hotfix Mar 14, 2023
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-17974 branch March 14, 2023 09:55
frappe-pr-bot pushed a commit that referenced this pull request Mar 21, 2023
# [14.29.0](v14.28.2...v14.29.0) (2023-03-21)

### Bug Fixes

* allow 5 column layout in doctype form ([7eb3bb4](7eb3bb4))
* Allow card actions (adding/dragging) if access to reference doctype ([bc5b362](bc5b362))
* Check perms on Kanban Column actions ([efa74bb](efa74bb))
* Check Reference Doctype perms & control indicator change ([c2fe3b0](c2fe3b0))
* clear contacts cache (backport [#20397](#20397)) ([#20406](#20406)) ([1905241](1905241))
* **Database:** clear background jobs and realtime logs on rollback ([#20236](#20236)) ([#20417](#20417)) ([750059b](750059b))
* Dispatch `update_order` always. Handle perm-wise action in backend ([e5c5cdb](e5c5cdb))
* handle image extraction while editing comment ([00c5f32](00c5f32))
* Hide Menu if empty & render columns without state change ([a9b5f04](a9b5f04))
* hide My Workspace sidebar section if empty in edit mode ([b51dd18](b51dd18))
* Hide Sort Selector in Kanban ([13be928](13be928))
* Kanban Board Menu Items Accessibility via perms ([4ffc7a5](4ffc7a5))
* **meta:** get_permitted_fields with no field-columns (backport [#20401](#20401)) ([#20405](#20405)) ([644c6c8](644c6c8))
* **patch:** move desk prop patch to post model sync ([#20361](#20361)) ([#20362](#20362)) ([661820a](661820a))
* **print:** Language set in document should have higher precedence (backport [#20336](#20336)) ([#20338](#20338)) ([a27178d](a27178d))
* server method to return evaluated dict of perms for a document ([d1446b8](d1446b8))
* Set link title in PDF ([716db05](716db05))
* sidebar becomes unhidden while removing skeleton ([71ac099](71ac099))
* skip InReadOnlyMode in error snapshots ([#20358](#20358)) ([#20359](#20359)) ([eb14fe1](eb14fe1))
* treat Phone as Data on list view ([06395dd](06395dd))
* **workspace:** Setup Dynamic Link if value exists ([b393d5b](b393d5b))

### Features

* clear integration log request logs ([#20373](#20373)) ([#20374](#20374)) ([4c48f55](4c48f55))
* configurable rounding methods (v14 port) ([#20330](#20330)) ([0d60385](0d60385)), closes [#20299](#20299)
* **minor:** log datetime in worker log  ([#20414](#20414)) ([#20418](#20418)) ([bfda74d](bfda74d))

### Performance Improvements

* Dont update list view data if list view not active ([#20396](#20396)) ([#20420](#20420)) ([3a6e307](3a6e307))
* rebuild website search index in background (backport [#17974](#17974)) ([#20335](#20335)) ([c1b0210](c1b0210))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants