-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minor): log datetime in worker log #20414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebsiteDeveloper
requested review from
a team and
phot0n
and removed request for
a team
March 21, 2023 01:49
github-actions
bot
added
the
add-test-cases
Add test case to validate fix or enhancement
label
Mar 21, 2023
WebsiteDeveloper
force-pushed
the
bugfix/worker-log-format
branch
from
March 21, 2023 02:02
6fd36a0
to
ed5cc62
Compare
phot0n
changed the title
fix: Change worker log format to use the same as the default logging …
feat(minor): log datetime in worker log
Mar 21, 2023
phot0n
approved these changes
Mar 21, 2023
phot0n
added
backport version-14-hotfix
backport to version 14
and removed
add-test-cases
Add test case to validate fix or enhancement
labels
Mar 21, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
(cherry picked from commit c5cfe8f)
phot0n
pushed a commit
that referenced
this pull request
Mar 21, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
# [14.29.0](v14.28.2...v14.29.0) (2023-03-21) ### Bug Fixes * allow 5 column layout in doctype form ([7eb3bb4](7eb3bb4)) * Allow card actions (adding/dragging) if access to reference doctype ([bc5b362](bc5b362)) * Check perms on Kanban Column actions ([efa74bb](efa74bb)) * Check Reference Doctype perms & control indicator change ([c2fe3b0](c2fe3b0)) * clear contacts cache (backport [#20397](#20397)) ([#20406](#20406)) ([1905241](1905241)) * **Database:** clear background jobs and realtime logs on rollback ([#20236](#20236)) ([#20417](#20417)) ([750059b](750059b)) * Dispatch `update_order` always. Handle perm-wise action in backend ([e5c5cdb](e5c5cdb)) * handle image extraction while editing comment ([00c5f32](00c5f32)) * Hide Menu if empty & render columns without state change ([a9b5f04](a9b5f04)) * hide My Workspace sidebar section if empty in edit mode ([b51dd18](b51dd18)) * Hide Sort Selector in Kanban ([13be928](13be928)) * Kanban Board Menu Items Accessibility via perms ([4ffc7a5](4ffc7a5)) * **meta:** get_permitted_fields with no field-columns (backport [#20401](#20401)) ([#20405](#20405)) ([644c6c8](644c6c8)) * **patch:** move desk prop patch to post model sync ([#20361](#20361)) ([#20362](#20362)) ([661820a](661820a)) * **print:** Language set in document should have higher precedence (backport [#20336](#20336)) ([#20338](#20338)) ([a27178d](a27178d)) * server method to return evaluated dict of perms for a document ([d1446b8](d1446b8)) * Set link title in PDF ([716db05](716db05)) * sidebar becomes unhidden while removing skeleton ([71ac099](71ac099)) * skip InReadOnlyMode in error snapshots ([#20358](#20358)) ([#20359](#20359)) ([eb14fe1](eb14fe1)) * treat Phone as Data on list view ([06395dd](06395dd)) * **workspace:** Setup Dynamic Link if value exists ([b393d5b](b393d5b)) ### Features * clear integration log request logs ([#20373](#20373)) ([#20374](#20374)) ([4c48f55](4c48f55)) * configurable rounding methods (v14 port) ([#20330](#20330)) ([0d60385](0d60385)), closes [#20299](#20299) * **minor:** log datetime in worker log ([#20414](#20414)) ([#20418](#20418)) ([bfda74d](bfda74d)) ### Performance Improvements * Dont update list view data if list view not active ([#20396](#20396)) ([#20420](#20420)) ([3a6e307](3a6e307)) * rebuild website search index in background (backport [#17974](#17974)) ([#20335](#20335)) ([c1b0210](c1b0210))
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
(cherry picked from commit c5cfe8f) # Conflicts: # frappe/utils/background_jobs.py
phot0n
added a commit
that referenced
this pull request
Apr 4, 2023
* feat(minor): log datetime in worker log (#20414) (cherry picked from commit c5cfe8f) # Conflicts: # frappe/utils/background_jobs.py * chore: resolve conflicts * chore: fix linter --------- Co-authored-by: Bernhard Sirlinger <WebsiteDeveloper@users.noreply.github.com> Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
# [13.53.0](v13.52.0...v13.53.0) (2023-04-11) ### Bug Fixes * allow `reset_otp_secret` only if Two Factor Auth is enabled (backport [#20506](#20506)) ([#20560](#20560)) ([e8025a4](e8025a4)) * better permission error for query_report ([#20643](#20643)) ([#20646](#20646)) ([d972af8](d972af8)) * change z-index of freeze component to make it appear above all components ([1878b87](1878b87)), closes [#20538](#20538) * child row form should be above freeze screen ([9201e84](9201e84)) * client script add to instead of replace ([0c7ac16](0c7ac16)) * client_script default value ([9ed7851](9ed7851)) * german translation of workflow state ([#20609](#20609)) ([#20615](#20615)) ([3769bdf](3769bdf)) * **grid row:** fix prettier hook check ([9309687](9309687)) * **grid row:** fix update_docfield_property function not updating grid row ([558f908](558f908)) * **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([ba3cf84](ba3cf84)) * log requests even if no response ([#20638](#20638)) ([#20639](#20639)) ([ae4f7dd](ae4f7dd)) * no optional chaining in v13 ([d08627b](d08627b)) * **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20641](#20641)) ([4d6b776](4d6b776)) * validate if doctype exists before syncing customisations ([#20598](#20598)) ([#20644](#20644)) ([32ba65f](32ba65f)) ### Features * add context to confirm dailog ([0e21299](0e21299)) * add context to prompt dialog ([1bbf9c9](1bbf9c9)) * make report name translatable (backport [#20608](#20608)) ([#20617](#20617)) ([a92e69e](a92e69e)) * **minor:** log datetime in worker log (backport [#20414](#20414)) ([#20569](#20569)) ([dccb6af](dccb6af))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19381