fix: cint -> avoid precision loss if already integer #25735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
(cherry picked from commit ea5e1b6) # Conflicts: # frappe/tests/test_utils.py
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
(cherry picked from commit ea5e1b6)
This was referenced Mar 29, 2024
ankush
added a commit
that referenced
this pull request
Mar 30, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
# [15.20.0](v15.19.1...v15.20.0) (2024-04-02) ### Bug Fixes * advertise insights to system manager only ([7046320](7046320)) * cint -> avoid precision loss if already integer ([#25735](#25735)) ([#25737](#25737)) ([6c822e0](6c822e0)) * **enqueue:** pass the original method argument here ([#25722](#25722)) ([2c14450](2c14450)), closes [/github.com/frappe/frappe/blob/87d121f47a4afc507442a97bf1854bb3d17f42c6/frappe/email/doctype/email_queue/email_queue.py#L735-L736](https://github.com//github.com/frappe/frappe/blob/87d121f47a4afc507442a97bf1854bb3d17f42c6/frappe/email/doctype/email_queue/email_queue.py/issues/L735-L736) * **event:** clear message after handling exception ([eb9e88e](eb9e88e)) * fieldname extraction (backport [#24411](#24411)) ([#25670](#25670)) ([ed4e1b3](ed4e1b3)), closes [#22892](#22892) * incorrect status on data import (backport [#25660](#25660)) ([#25703](#25703)) ([0165c75](0165c75)) * incorrect UI icon for desc sort ([#25687](#25687)) ([#25689](#25689)) ([f7f2849](f7f2849)) * invalid filter on email acccount ([#25674](#25674)) ([#25676](#25676)) ([c15b47a](c15b47a)) * let's colored tags in listview ([#25552](#25552)) ([4e17959](4e17959)) * make ads translatable ([217ef0b](217ef0b)) * make insights ad translatable ([43e6734](43e6734)) * message update in custom app if is_standard ([#25754](#25754)) ([86ad2e6](86ad2e6)) * non-html notifications from files ([a35e9ba](a35e9ba)) * preserve original error message ([#25682](#25682)) ([#25685](#25685)) ([3d364b7](3d364b7)) * reserved keywords as col name ([#25718](#25718)) ([#25726](#25726)) ([fca1c1a](fca1c1a)) * **restore:** check backup directory and bench directory if we can't find the file ([e6e4258](e6e4258)) * translatable web footer ([99bbd94](99bbd94)) * Use CssParser to correctly pass options to wkhtmltopdf ([e9811ea](e9811ea)) * Use doctype setting to set auto-extracted file as private (backport [#24828](#24828)) ([#25673](#25673)) ([14ccbe7](14ccbe7)) ### Features * allow skipping msgprint ([59813db](59813db)), closes [/github.com/frappe/frappe/blob/version-15/frappe/desk/doctype/event/event.py#L398](https://github.com//github.com/frappe/frappe/blob/version-15/frappe/desk/doctype/event/event.py/issues/L398) * **customize_form:** allow setting `creation` as a default sort field ([#25760](#25760)) ([d540c72](d540c72)) * **notification:** specify message type (html, md, txt) ([e9a8a14](e9a8a14)) ### Reverts * Revert "fix: message update in custom app if is_standard (#25754)" (#25767) ([f5a17f7](f5a17f7)), closes [#25754](#25754) [#25767](#25767)
ankush
added a commit
that referenced
this pull request
Apr 6, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
# [14.71.0](v14.70.0...v14.71.0) (2024-04-09) ### Bug Fixes * add params in make_request arguments ([e16ebb7](e16ebb7)) * auto add modified index when sort_field is set to it (backport [#25686](#25686)) ([#25785](#25785)) ([0d57f1e](0d57f1e)) * bigint validation (backport [#25733](#25733)) ([#25821](#25821)) ([b2608b3](b2608b3)) * check if user exists in browse command ([a8c09d3](a8c09d3)) * cint -> avoid precision loss if already integer ([#25735](#25735)) ([#25736](#25736)) ([176cbd3](176cbd3)) * copy paste from Excel (issue [#24371](#24371)) ([30da5c5](30da5c5)) * copy paste from Excel (issue [#24371](#24371)) ([8d3d2e9](8d3d2e9)) * don't show bulk actions for doctype with workflow ([6703592](6703592)) * dont allow querying files to website users (backport [#25094](#25094)) ([#25700](#25700)) ([da5953c](da5953c)) * Get filter value based on depends_on field ([#25861](#25861)) ([#25863](#25863)) ([31b4453](31b4453)) * **grid:** don't crash if row doesn't exist ([db85d3c](db85d3c)) * **grid:** ensure that `doc.name` is truthy before proceeding ([#25800](#25800)) ([#25828](#25828)) ([71edfab](71edfab)) * Handle empty value of datetime control ([291ab66](291ab66)) * **layout:** handle `fieldobj` being null ([4c11499](4c11499)) * **link:** get_input_value returns `""` ([#25878](#25878)) ([#25882](#25882)) ([1e70ac8](1e70ac8)) * make_request - prevents an error during response parsing if the response body is empty. ([#24613](#24613)) ([d5c86a7](d5c86a7)) * max-width of email attachment filename ([d678571](d678571)) * only try JSON if content-type says so ([#24936](#24936)) ([e3c5ec4](e3c5ec4)) * respect custom filters on report export ([#25886](#25886)) ([f32b5d8](f32b5d8)) * type error in workflow ([#25847](#25847)) ([#25848](#25848)) ([835e43f](835e43f)) ### Features * add upstream json argument to integrations make_request ([#22462](#22462)) ([46a396e](46a396e)) * Include `before_print` in doctype event of Server Script (backport [#25858](#25858)) ([a36c68c](a36c68c)) ### Performance Improvements * **Scheduling:** add jitter to job scheduling ([#25856](#25856)) ([2a88f87](2a88f87)), closes [#19007](#19007)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.