Doctype Links not updating

[ajiragroup]

Information about bug

I had added a doctype link to project doctype. Now I want to delete that link. When doing so, this happens:

1.mp4

Module

projects

Version

erpnext 15.16.2
frappe 15.17.1

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

[karanwilson]

Hi @ajiragroup, this issue is also happening in Version-14;
Seems like Frappe team is also working in this issue; following are some error logs from the console:-

grid_row.js:126 TypeError: Cannot read properties of undefined (reading 'name')
at GridRow.refresh_field (grid_row.js:1438:29)
at grid_row.js:710:10
at Array.forEach ()
at GridRow.setup_columns (grid_row.js:688:29)
at GridRow.render_row (grid_row.js:309:8)
at GridRow.refresh (grid_row.js:206:9)
at Grid.render_result_rows (grid.js:479:14)
at Grid.refresh (grid.js:432:8)
at grid_row.js:121:18
(anonymous) @ grid_row.js:126
Promise.catch (async)
remove @ grid_row.js:124
(anonymous) @ grid.js:239
Promise.then (async)
(anonymous) @ dom.js:262
frappe.run_serially @ dom.js:260
delete_rows @ grid.js:260
(anonymous) @ utils.js:1071
dispatch @ jquery.js:5135
elemData.handle @ jquery.js:4939

============================================

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'name')
at GridRow.refresh_field (grid_row.js:1438:29)
at grid_row.js:710:10
at Array.forEach ()
at GridRow.setup_columns (grid_row.js:688:29)
at GridRow.render_row (grid_row.js:309:8)
at GridRow.refresh (grid_row.js:206:9)
at Grid.render_result_rows (grid.js:479:14)
at Grid.refresh (grid.js:432:8)
at grid.js:254:10

============================================

Uncaught TypeError: Cannot read properties of undefined (reading '__checked')
at grid.js:326:20
at Array.map ()
at Grid.get_selected_children (grid.js:325:5)
at Grid.delete_rows (grid.js:232:32)
at HTMLButtonElement. (utils.js:1071:20)
at HTMLDivElement.dispatch (jquery.js:5135:27)
at elemData.handle (jquery.js:4939:28)

[karanwilson]

Hi @ajiragroup ,

To resolve this bug, please access the following file of the Frappe App (in your instance):-
frappe-bench/apps/frappe/frappe/custom/doctype/customize_form/customize_form.js

Please update this file with the added lines of code as per the attached file:-
customize_form.js.txt
(I added the txt extension to the file in order to attach it here)

The following lines in bold were added to the attached "customize_form.js" file:-

frappe.ui.form.on("DocType Link", {
before_links_remove: function (frm, doctype, name) {
...
parenttype = row.parenttype; // used in the event links_remove
parent = row.parent; // used in the event links_remove
...
},
...
links_remove: function (frm, doctype, name) {
// replicate the changed rows from the browser's copy of the parent doc to the current 'Customize Form' doc
let parent_doc = locals[parenttype][parent];
frm.doc.links = parent_doc.links;
},
});

frappe.ui.form.on("DocType Action", {
before_actions_remove: function (frm, doctype, name) {
...
parenttype = row.parenttype; // used in the event actions_remove
parent = row.parent; // used in the event actions_remove
...
},
...
actions_remove: function (frm, doctype, name) {
// replicate the changed rows from the browser's copy of the parent doc to the current 'Customize Form' doc
let parent_doc = locals[parenttype][parent];
frm.doc.actions = parent_doc.actions;
},
});

frappe.ui.form.on("DocType State", {
before_states_remove: function (frm, doctype, name) {
...
parenttype = row.parenttype; // used in the event states_remove
parent = row.parent; // used in the event states_remove
...
},
...
states_remove: function (frm, doctype, name) {
// replicate the changed rows from the browser's copy of the parent doc to the current 'Customize Form' doc
let parent_doc = locals[parenttype][parent];
frm.doc.states = parent_doc.states;
},
});

@nabinhait @Nihantra-Patel please let me know whether I should submit a PR for this.

[karanwilson]

Edited the frm.refresh_fields() statements above to add the specific fieldnames.
Also made the edit in the attached file "customize_form.js.txt"

[karanwilson]

Upon final testing, I realised that the frm.refresh_field() or frm.refresh_fields() are indeed redundant;
there are standard refresh triggers that happen upon any row changes;
Hence removed these refresh_field statements from the above comment and from the attached file.

[karanwilson]

This issue has been resolved in Frappe version 15.29.1 and higher.

#26344 (comment)

@ajiragroup @nabinhait