fix: delete old user notification settings when merging users (backport #26604) #26619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where merging users in the Frappe framework resulted in an error due to existing notification settings for the user being merged. The change ensures that the old user's notification settings are deleted during the merge process, preventing conflicts and allowing the merge to be completed successfully.
Detailed Explanation
Issue:
When attempting to merge two users, an error was encountered if the user being merged had existing notification settings. For example, merging
user2
(user2@example.com
) intouser1
(user1@example.com
) would fail with the following error:Error Traceback