Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UX): multi-tab experience (backport #26309) #26646

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 3, 2024

image

If you get this error often, it's most likely because:

  1. You have multiple tabs open
  2. You get logged out in one tab and you login.
  3. Other tabs don't know that this has happened.
  4. Browser sends new SID cookie correctly but it has no way of knowing new CSRF token.
  5. Problem auto resolves if you reload page.

Fix:

  1. On booting new session update other tabs/workers in same browser to avoid "invalid requests".
  2. On logging in as diff user - notify user to reload page.

Not going to force reload to avoid potential data loss.

Ref: https://developer.mozilla.org/en-US/docs/Web/API/BroadcastChannel


This is an automatic backport of pull request #26309 done by Mergify.

- On booting new session update other sessions in same browser to avoid
  "invalid requests"
- On logging in as diff user - notify user to reload page.

Not going to force reload to avoid potential data loss.

(cherry picked from commit 0929c23)
@mergify mergify bot requested a review from a team June 3, 2024 06:51
@mergify mergify bot assigned ankush Jun 3, 2024
@mergify mergify bot requested review from rutwikhdev and removed request for a team June 3, 2024 06:51
@ankush ankush enabled auto-merge (squash) June 3, 2024 06:52
@ankush ankush merged commit 3e4fff7 into version-15-hotfix Jun 3, 2024
19 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-26309 branch June 3, 2024 07:02
frappe-pr-bot pushed a commit that referenced this pull request Jun 4, 2024
## [15.29.1](v15.29.0...v15.29.1) (2024-06-04)

### Bug Fixes

* **address_query:** show search fields in description if set ([4db0b53](4db0b53))
* **address_query:** use title field if set ([01a00e3](01a00e3))
* allow creation of workspace based on desk role perms ([fb898f7](fb898f7))
* Auto Email Report not working when Add Total Row is enabled ([#26668](#26668)) ([e585657](e585657))
* Avoid concurrent TODO updates ([#26594](#26594)) ([cee96b9](cee96b9))
* bypass IP restriction for the methods required for our socketio backend ([42011c9](42011c9))
* **checkbox:** Fix checkbox size on small screens ([#26596](#26596)) ([#26612](#26612)) ([fc2a852](fc2a852))
* delete old user notification settings when merging users ([#26604](#26604)) ([#26619](#26619)) ([af1a47d](af1a47d))
* don't copy "Standard" on dashboard chart (backport [#26649](#26649)) ([#26651](#26651)) ([719522d](719522d))
* front-end bug in 'customize_form.js', triggered by delete actions on child-tables ([#26344](#26344)) ([b9f4845](b9f4845)), closes [#26041](#26041) [#26041](https://github.com/frappe/issues/26041) [#26041](#26041)
* kanban filters fixes ([#26605](#26605)) ([#26610](#26610)) ([af7f550](af7f550))
* **link-preview:** Correct synchronization of preview data on change. ([#26641](#26641)) ([#26654](#26654)) ([c34c1d1](c34c1d1))
* **make_request:** don't blindly try to check the content-type ([2fc914f](2fc914f))
* **number_card:** ensure value is returned ([0a91f04](0a91f04))
* **UX:** multi-tab experience ([#26309](#26309)) ([#26646](#26646)) ([3e4fff7](3e4fff7))

### Performance Improvements

* memory leak on kanban refresh ([#26597](#26597)) ([#26599](#26599)) ([8b8a297](8b8a297))
* rearrange some frequent jobs ([#26591](#26591)) ([#26603](#26603)) ([d9b7d73](d9b7d73))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants