feat: telemetry using posthog #20825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #20825 +/- ##
===========================================
- Coverage 63.95% 63.88% -0.08%
===========================================
Files 759 761 +2
Lines 68789 68844 +55
Branches 6219 6224 +5
===========================================
- Hits 43997 43983 -14
- Misses 21275 21323 +48
- Partials 3517 3538 +21
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@WebsiteDeveloper yeah we will make it configurable. This is rough PR, ignore for now. |
|
Alright :) just saw it. Did not notice it got opened like 30 mins ago |
ankush
force-pushed
the
posthog_poc
branch
2 times, most recently
from
706746d
to
6e3352a
Compare
ankush
added
the
defer backport
ankush
requested review from
a team and
shariquerik
and removed request for
a team
ankush
added
backport version-14-hotfix
ankush
added a commit
that referenced
this pull request
May 8, 2023
* feat: let users disable telemetry from system settings (cherry picked from commit 0d1c7fe) # Conflicts: # frappe/core/doctype/system_settings/system_settings.json * feat: telemetry using posthog (cherry picked from commit 87a8819) * feat: setup wizard progress telemetry (cherry picked from commit 6c3f29e) * feat: add python posthog library (cherry picked from commit f63c420) # Conflicts: # pyproject.toml * feat: let user opt out of telemetry from setup (cherry picked from commit 93c326b) # Conflicts: # frappe/core/doctype/system_settings/system_settings.json * refactor: reduce duplication (cherry picked from commit db4cd1a) * chore: conflicts * chore: track onboarding progress Easy self-onboarding has been hardest to get right in complex business apps, even though we have worked on this for long long time we have no clear idea on how well it works, or if it's severly lacking. We want to improve this by first understanding how efficient current system is. This PR adds basic telemetry for which steps are being completed, which are skipped and what onboarding group is dismissed completely. * Revert "chore: conflicts" This reverts commit 39e5751. * chore: conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 9, 2023
# [14.36.0](v14.35.0...v14.36.0) (2023-05-09) ### Bug Fixes * ensure that `get_last_email` returns the most recent email (backport [#20711](#20711)) ([624f96b](624f96b)) * escape html from listview row title ([56bec1d](56bec1d)) * escape html from workspace title ([e68fc43](e68fc43)) * ignore virtual doctypes during data export ([#20891](#20891)) ([#20899](#20899)) ([d6bfaae](d6bfaae)) * make operator in link filters translatable (backport [#20884](#20884)) ([#20911](#20911)) ([1ec3bad](1ec3bad)) * message.py executing script ([#20887](#20887)) ([#20897](#20897)) ([1bcf5d4](1bcf5d4)) * **multi-pdf:** change response type to pdf ([997559c](997559c)) * **oauth:** add exp to idToken ([#20694](#20694)) ([#20903](#20903)) ([1a8e671](1a8e671)) * reload communication before re-save ([#20914](#20914)) ([#20921](#20921)) ([37a8ec0](37a8ec0)) * set default letterhead and print format ([a5a6965](a5a6965)) * strip comma, space from recipients before sending email for auto repeat ([#20940](#20940)) ([#20945](#20945)) ([042a1d2](042a1d2)) * translate lowercase operators to german ([#20912](#20912)) ([#20916](#20916)) ([c47b146](c47b146)) * type hints for get_address_display ([#20923](#20923)) ([#20924](#20924)) ([15df963](15df963)) * use smaller font only if the report doesnt have a standard print format ([#20878](#20878)) ([#20947](#20947)) ([35165d0](35165d0)) ### Features * helper method for address display ([#20900](#20900)) ([#20901](#20901)) ([f914770](f914770)) * telemetry using posthog (backport [#20825](#20825)) ([#20934](#20934)) ([bbe29ee](bbe29ee)) ### Performance Improvements * get all file data at once when downloading private file ([#20902](#20902)) ([e106594](e106594))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds posthog for collecting minimal site-level info to find out issues blocking adoption.
No individual user is identified and no personal data is collected, only the site is identified as "unique" user.
Summary of change:
WARNING: This is experimental and should be treated "internal", anything or everything in this PR is subjected to change or get removed without any warning.
no-docs