fix: make operator in link filters translatable #20884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
requested review from
a team,
phot0n and
marination
and removed request for
a team
barredterra
force-pushed
the
translate-operator
branch
from
9cac579
to
7892a8b
Compare
barredterra
changed the title
|
The unscrubbed filters will start looking a bit indistinguishable isn't it? since they will have similar casing. we could just enable normal translations? edit: actually doesnt look that bad
still i feel like they should be in lower case? |
|
@phot0n I have no strong opinions on that. I only unscrubbed in order to reuse existing translations from list filters. We can just as well add these translations for german. |
|
I've removed the unscrubbing in 4418aa3 feel free to add translations for those :) |
barredterra
added
backport version-13-hotfix
backport version-14-hotfix
This was referenced May 5, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 9, 2023
## [13.56.2](v13.56.1...v13.56.2) (2023-05-09) ### Bug Fixes * ensure that `get_last_email` returns the most recent email ([#20711](#20711)) ([d416159](d416159)) * make operator in link filters translatable (backport [#20884](#20884)) ([#20910](#20910)) ([688a2b4](688a2b4)) * merge conflict ([64d5c8f](64d5c8f)) * translate lowercase operators to german ([#20912](#20912)) ([#20915](#20915)) ([598bdaf](598bdaf)) * use smaller font only if the report doesnt have a standard print format (backport [#20878](#20878)) ([#20946](#20946)) ([8b0c1f8](8b0c1f8))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 9, 2023
# [14.36.0](v14.35.0...v14.36.0) (2023-05-09) ### Bug Fixes * ensure that `get_last_email` returns the most recent email (backport [#20711](#20711)) ([624f96b](624f96b)) * escape html from listview row title ([56bec1d](56bec1d)) * escape html from workspace title ([e68fc43](e68fc43)) * ignore virtual doctypes during data export ([#20891](#20891)) ([#20899](#20899)) ([d6bfaae](d6bfaae)) * make operator in link filters translatable (backport [#20884](#20884)) ([#20911](#20911)) ([1ec3bad](1ec3bad)) * message.py executing script ([#20887](#20887)) ([#20897](#20897)) ([1bcf5d4](1bcf5d4)) * **multi-pdf:** change response type to pdf ([997559c](997559c)) * **oauth:** add exp to idToken ([#20694](#20694)) ([#20903](#20903)) ([1a8e671](1a8e671)) * reload communication before re-save ([#20914](#20914)) ([#20921](#20921)) ([37a8ec0](37a8ec0)) * set default letterhead and print format ([a5a6965](a5a6965)) * strip comma, space from recipients before sending email for auto repeat ([#20940](#20940)) ([#20945](#20945)) ([042a1d2](042a1d2)) * translate lowercase operators to german ([#20912](#20912)) ([#20916](#20916)) ([c47b146](c47b146)) * type hints for get_address_display ([#20923](#20923)) ([#20924](#20924)) ([15df963](15df963)) * use smaller font only if the report doesnt have a standard print format ([#20878](#20878)) ([#20947](#20947)) ([35165d0](35165d0)) ### Features * helper method for address display ([#20900](#20900)) ([#20901](#20901)) ([f914770](f914770)) * telemetry using posthog (backport [#20825](#20825)) ([#20934](#20934)) ([bbe29ee](bbe29ee)) ### Performance Improvements * get all file data at once when downloading private file ([#20902](#20902)) ([e106594](e106594))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate operators such as "in", "not in", "descendents of", etc. in link field filters.
Translations already exist for the unscrubbed version, therefore we unscrub before translating.