fix: reload communication before re-save

[ankush]

Solves:

Traceback with variables (most recent call last):
  File "apps/frappe/frappe/email/doctype/email_account/email_account.py", line 453, in receive
    communication = mail.process()
      self = <EmailAccount: Sales>
      exceptions = []
      inbound_mails = [<frappe.email.receive.InboundMail object at 0x7ff8b2fe56c0>, <frappe.email.receive.InboundMail object at 0x7ff8b2fe4af0>, <frappe.email.receive.InboundMail object at 0x7ff8b2fe58a0>]
      mail = <frappe.email.receive.InboundMail object at 0x7ff8b2fe4af0>
      communication = <Communication: 84e7fa273c>
  File "apps/frappe/frappe/email/receive.py", line 619, in process
    return self._build_communication_doc()
      self = <frappe.email.receive.InboundMail object at 0x7ff8b2fe4af0>
      communication = None
  File "apps/frappe/frappe/email/receive.py", line 655, in _build_communication_doc
    communication.save()
      self = <frappe.email.receive.InboundMail object at 0x7ff8b2fe4af0>
      reference_doc = <Lead: Lead-23-24-02732>
      communication = <Communication: 5639d5b8a5>
  File "apps/frappe/frappe/model/document.py", line 316, in save
    return self._save(*args, **kwargs)
      self = <Communication: 5639d5b8a5>
      args = ()
      kwargs = {}
  File "apps/frappe/frappe/model/document.py", line 345, in _save
    self.check_if_latest()
      self = <Communication: 5639d5b8a5>
      ignore_permissions = None
      ignore_version = None
  File "apps/frappe/frappe/model/document.py", line 779, in check_if_latest
    frappe.msgprint(
      self = <Communication: 5639d5b8a5>
      previous = <Communication: 5639d5b8a5>
  File "apps/frappe/frappe/__init__.py", line 491, in msgprint
    _raise_exception()
      title = None
      as_table = False
      as_list = False
      indicator = 'red'
      alert = False
      primary_action = None
      is_minimizable = False
      wide = False
      sys = <module 'sys' (built-in)>
      out = {'message': 'Error: Document has been modified after you have opened it (2023-05-04 18:30:40.492993, 2023-05-04 18:30:41.221896). Please refresh to get the latest document.', 'title': 'Message', 'indicator': 'red', 'raise_exception': 1}
      _raise_exception = <function msgprint.<locals>._raise_exception at 0x7ff8b0b87d90>
      _strip_html_tags = <functools._lru_cache_wrapper object at 0x7ff8b093d9b0>
      inspect = <module 'inspect' from '/usr/lib/python3.10/inspect.py'>
      msg = 'Error: Document has been modified after you have opened it (2023-05-04 18:30:40.492993, 2023-05-04 18:30:41.221896). Please refresh to get the latest document.'
      raise_exception = <class 'frappe.exceptions.TimestampMismatchError'>
      strip_html_tags = <function strip_html_tags at 0x7ff8ba8bc310>
  File "apps/frappe/frappe/__init__.py", line 440, in _raise_exception
    raise raise_exception(msg)
      inspect = <module 'inspect' from '/usr/lib/python3.10/inspect.py'>
      msg = 'Error: Document has been modified after you have opened it (2023-05-04 18:30:40.492993, 2023-05-04 18:30:41.221896). Please refresh to get the latest document.'
      raise_exception = <class 'frappe.exceptions.TimestampMismatchError'>
frappe.exceptions.TimestampMismatchError: Error: Document has been modified after you have opened it (2023-05-04 18:30:40.492993, 2023-05-04 18:30:41.221896). Please refresh to get the latest document.

since db_set and db.set_value are present in post save/insert hooks for communication doctype, it causes this error very frequently

[codecov]

Codecov Report

Merging #20914 (cd516ff) into develop (bb14fe6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20914   +/-   ##
========================================
  Coverage    63.95%   63.96%           
========================================
  Files          761      761           
  Lines        68860    68861    +1     
  Branches      6227     6227           
========================================
+ Hits         44042    44047    +5     
+ Misses       21262    21258    -4     
  Partials      3556     3556           

Flag	Coverage Δ
server	68.93% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.