Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: telemetry using posthog (backport #20825) #20934

Merged
merged 10 commits into from
May 8, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2023

This is an automatic backport of pull request #20825 done by Mergify.
Cherry-pick of 0d1c7fe has failed:

On branch mergify/bp/version-14-hotfix/pr-20825
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 0d1c7fee42.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/core/doctype/system_settings/system_settings.json

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of f63c420 has failed:

On branch mergify/bp/version-14-hotfix/pr-20825
Your branch is ahead of 'origin/version-14-hotfix' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit f63c420798.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/desk/page/setup_wizard/setup_wizard.js
	modified:   frappe/desk/page/setup_wizard/setup_wizard.py
	modified:   frappe/public/js/telemetry/index.js
	modified:   frappe/utils/telemetry.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pyproject.toml

Cherry-pick of 93c326b has failed:

On branch mergify/bp/version-14-hotfix/pr-20825
Your branch is ahead of 'origin/version-14-hotfix' by 4 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 93c326b971.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/desk/page/setup_wizard/setup_wizard.js
	modified:   frappe/desk/page/setup_wizard/setup_wizard.py
	modified:   frappe/public/js/telemetry/index.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/core/doctype/system_settings/system_settings.json

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

ankush added 6 commits May 8, 2023 11:24
(cherry picked from commit 0d1c7fe)

# Conflicts:
#	frappe/core/doctype/system_settings/system_settings.json
(cherry picked from commit 87a8819)
(cherry picked from commit f63c420)

# Conflicts:
#	pyproject.toml
(cherry picked from commit 93c326b)

# Conflicts:
#	frappe/core/doctype/system_settings/system_settings.json
(cherry picked from commit db4cd1a)
@mergify mergify bot requested review from a team and shariquerik and removed request for a team May 8, 2023 11:24
@mergify mergify bot added the conflicts label May 8, 2023
@mergify mergify bot assigned ankush May 8, 2023
ankush added 2 commits May 8, 2023 16:59
Easy self-onboarding has been hardest to get right in complex business
apps, even though we have worked on this for long long time we have no
clear idea on how well it works, or if it's severly lacking.

We want to improve this by first understanding how efficient current
system is.

This PR adds basic telemetry for which steps are being completed, which
are skipped and what onboarding group is dismissed completely.
@ankush ankush removed the conflicts label May 8, 2023
@ankush ankush added the squash label May 8, 2023
@ankush ankush merged commit bbe29ee into version-14-hotfix May 8, 2023
4 of 10 checks passed
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-20825 branch May 8, 2023 11:51
frappe-pr-bot pushed a commit that referenced this pull request May 9, 2023
# [14.36.0](v14.35.0...v14.36.0) (2023-05-09)

### Bug Fixes

* ensure that `get_last_email` returns the most recent email (backport [#20711](#20711)) ([624f96b](624f96b))
* escape html from listview row title ([56bec1d](56bec1d))
* escape html from workspace title ([e68fc43](e68fc43))
* ignore virtual doctypes during data export ([#20891](#20891)) ([#20899](#20899)) ([d6bfaae](d6bfaae))
* make operator in link filters translatable (backport [#20884](#20884)) ([#20911](#20911)) ([1ec3bad](1ec3bad))
* message.py executing script ([#20887](#20887)) ([#20897](#20897)) ([1bcf5d4](1bcf5d4))
* **multi-pdf:** change response type to pdf ([997559c](997559c))
* **oauth:** add exp to idToken ([#20694](#20694)) ([#20903](#20903)) ([1a8e671](1a8e671))
* reload communication before re-save ([#20914](#20914)) ([#20921](#20921)) ([37a8ec0](37a8ec0))
* set default letterhead and print format ([a5a6965](a5a6965))
* strip comma, space from recipients before sending email for auto repeat ([#20940](#20940)) ([#20945](#20945)) ([042a1d2](042a1d2))
* translate lowercase operators to german ([#20912](#20912)) ([#20916](#20916)) ([c47b146](c47b146))
* type hints for get_address_display ([#20923](#20923)) ([#20924](#20924)) ([15df963](15df963))
* use smaller font only if the report doesnt have a standard print format ([#20878](#20878)) ([#20947](#20947)) ([35165d0](35165d0))

### Features

* helper method for address display ([#20900](#20900)) ([#20901](#20901)) ([f914770](f914770))
* telemetry using posthog (backport [#20825](#20825)) ([#20934](#20934)) ([bbe29ee](bbe29ee))

### Performance Improvements

* get all file data at once when downloading private file ([#20902](#20902)) ([e106594](e106594))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants