-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query_doctypes): Allow search in translated name #22590
Conversation
e38f11b
to
e02a6f0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #22590 +/- ##
===========================================
- Coverage 62.36% 62.30% -0.07%
===========================================
Files 768 768
Lines 73575 73520 -55
Branches 6340 6337 -3
===========================================
- Hits 45888 45808 -80
- Misses 24096 24123 +27
+ Partials 3591 3589 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
e02a6f0
to
74dfb8a
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
* fix(query_doctypes): Allow search in translated name * test: Add test for DocType search in foreign language (cherry picked from commit 89aab5d) # Conflicts: # frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py
When searching for a DocType while adding a Shortcut block in a workspace, I'm using my language (i.e. French), but the search only works in English.
Used in two locations:
frappe/frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.js
Line 21 in a0783fa
frappe/frappe/public/js/frappe/widgets/widget_dialog.js
Line 358 in a0783fa