Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v14 #25535

Merged
merged 44 commits into from
Mar 19, 2024
Merged

chore: release v14 #25535

merged 44 commits into from
Mar 19, 2024

Commits on Mar 12, 2024

  1. perf: compact prepared report files

    No one reads these, no need to indent them.
    
    (cherry picked from commit 135fd33)
    
    # Conflicts:
    #	frappe/core/doctype/prepared_report/prepared_report.py
    ankush authored and mergify[bot] committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0aa3c8e View commit details
    Browse the repository at this point in the history
  2. fix: log mariadb console usage

    (cherry picked from commit 2d75dbb)
    
    # Conflicts:
    #	frappe/commands/utils.py
    ankush authored and mergify[bot] committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6f4981c View commit details
    Browse the repository at this point in the history
  3. chore: conflict

    ankush committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a7e9b18 View commit details
    Browse the repository at this point in the history
  4. chore: conflicts

    ankush committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b4c4524 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #25376 from frappe/mergify/bp/version-14-hotfix/pr…

    …-25366
    
    fix: log mariadb console usage (backport #25366)
    ankush committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    217639a View commit details
    Browse the repository at this point in the history
  6. Merge pull request #25374 from frappe/mergify/bp/version-14-hotfix/pr…

    …-25370
    
    perf: compact prepared report files (backport #25370)
    ankush committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    53492f8 View commit details
    Browse the repository at this point in the history
  7. fix!: console logs can't be deleted (#25372)

    (cherry picked from commit 54a2b08)
    
    # Conflicts:
    #	frappe/desk/doctype/console_log/console_log.json
    #	frappe/desk/doctype/console_log/console_log.py
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fee8619 View commit details
    Browse the repository at this point in the history
  8. fix: Log ipython commands (backport #25364) (#25367)

    * fix: Log ipython commands
    
    (cherry picked from commit 8bdc88f)
    
    # Conflicts:
    #	frappe/commands/utils.py
    
    * fix: print frappe.log message
    
    (cherry picked from commit 4ef0740)
    
    # Conflicts:
    #	frappe/__init__.py
    
    * chore: conflicts
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    997628c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. fix: dont add trailing decimal separator (#25389) (#25390)

    (cherry picked from commit ddaf1d2)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    08e8d8c View commit details
    Browse the repository at this point in the history
  2. feat: move bulk print operation to the background (backport #25358) (#…

    …25396)
    
    * feat: move bulk print operation to the background
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit bf6cb1a)
    
    # Conflicts:
    #	frappe/utils/print_format.py
    
    * fix: open PDF in new tab
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 5d0db0c)
    
    * fix: update message
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 9bf22b7)
    
    * fix: add back a limitation to number of the documents
    
    Don't allow printing more than 500 documents
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 1caae03)
    
    * fix: let backend generate task ID
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 5a6bff9)
    
    * fix: make filename more user-friendly
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 508e4d9)
    
    * refactor(bulk_print): choose queue dynamically
    
    Update docstrings and type hints a bit
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 5e37ac7)
    
    * refactor: add in a new endpoint for background printing
    
    Let the original one stay as-is for backward compatibility
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 0ec3e4a)
    
    # Conflicts:
    #	frappe/utils/print_format.py
    
    * fix: unsubscribe from task after completion
    
    Also update event name to be more logical
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 6a5af14)
    
    * refactor: make download button a primary action, update text
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit 5f087ed)
    
    * chore: fix conflicts
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    
    ---------
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    Co-authored-by: Akhil Narang <me@akhilnarang.dev>
    mergify[bot] and akhilnarang committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4508239 View commit details
    Browse the repository at this point in the history
  3. fix: handle parent rename in child workspace

    (cherry picked from commit b25fd31)
    ankush authored and mergify[bot] committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c3d9e1f View commit details
    Browse the repository at this point in the history
  4. Merge pull request #25407 from frappe/mergify/bp/version-14-hotfix/pr…

    …-25406
    
    fix: handle parent rename in child workspace (backport #25406)
    ankush committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a41523d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Revert "feat: move bulk print operation to the background (backport #…

    …25358) (#25396)" (#25400)
    
    Some `frappe.realtime` APIs are different now, will figure it out later if required on v14
    
    This reverts commit 4508239.
    akhilnarang committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    490f031 View commit details
    Browse the repository at this point in the history
  2. fix: skip virtual doctype in tags

    (cherry picked from commit 00030a3)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b2ae437 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #25421 from frappe/mergify/bp/version-14-hotfix/pr…

    …-25420
    
    fix: skip virtual doctype in tags patch (backport #25420)
    ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    96dcee1 View commit details
    Browse the repository at this point in the history
  4. fix: validate homepage paths (backport #25409) (#25411)

    * fix: validate homepage paths
    
    (cherry picked from commit d9d2943)
    
    # Conflicts:
    #	frappe/core/doctype/role/role.json
    #	frappe/website/path_resolver.py
    
    * fix: clear routing cache on homepage change
    
    (cherry picked from commit d758af5)
    
    # Conflicts:
    #	frappe/tests/test_caching.py
    #	frappe/website/router.py
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ee1c8e3 View commit details
    Browse the repository at this point in the history
  5. fix: filters can use more than 140 chars

    (cherry picked from commit 234ba82)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d04bff9 View commit details
    Browse the repository at this point in the history
  6. fix: debounce filter refresh

    (cherry picked from commit 6ecac9d)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7f65916 View commit details
    Browse the repository at this point in the history
  7. fix: Avoid setting filter on now/today button

    (cherry picked from commit 51f1a5f)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    83766c0 View commit details
    Browse the repository at this point in the history
  8. fix: hide datepicker after picking date

    (cherry picked from commit 0a9f6ca)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    39796ea View commit details
    Browse the repository at this point in the history
  9. fix: avoid closing filter popover on any date picker interactions

    (cherry picked from commit 8315d2a)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0784e61 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #25424 from frappe/mergify/bp/version-14-hotfix/pr…

    …-25413
    
    fix: wait for datepicker changes to propogate (backport #25413)
    ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bb1fb13 View commit details
    Browse the repository at this point in the history
  11. fix: consider all datepicker elements (#25426)

    (cherry picked from commit 6d89d54)
    ankush authored and mergify[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ad79301 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7a81700 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #25427 from frappe/mergify/bp/version-14-hotfix/pr…

    …-25426
    
    fix: consider all datepicker elements (backport #25426)
    ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    de5a2b3 View commit details
    Browse the repository at this point in the history
  14. fix: allow exporting large reports that can't be rendered (backport #…

    …25395) (#25404)
    
    * fix: dont render very large reports, offer export instead
    
    (cherry picked from commit 65fb8dc)
    
    # Conflicts:
    #	frappe/public/js/frappe/views/reports/query_report.js
    
    * chore: conflicts
    
    * fix: make excel export work without rendering
    
    * fix: hide CSV option if not available
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b3f4d5d View commit details
    Browse the repository at this point in the history
  15. ci: ui tests mess (#25430)

    * ci: disable parallel builds
    
    Reduces flake from random order of execution
    
    * ci: reduce cypress retries
    
    Rarely works, wastes time
    
    * fix: wait for stupid text editor
    
    * chore: remove breadcrumbs test for web form
    
    niche feature, flaky test
    ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0eaa472 View commit details
    Browse the repository at this point in the history
  16. fix: don't allow setting an invalid rating (#22633) (#25432)

    * feat: don't allow setting an invalid rating
    
    Convert anything <0 to 0, and anything >1 to 1
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    
    * chore: add in tests for rating
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    
    ---------
    
    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    (cherry picked from commit b601131)
    
    Co-authored-by: Akhil Narang <me@akhilnarang.dev>
    mergify[bot] and akhilnarang committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    502b907 View commit details
    Browse the repository at this point in the history
  17. fix: child table rating fields (#25433) (#25435)

    (cherry picked from commit f6e58f2)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    57cf161 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2f3c90e View commit details
    Browse the repository at this point in the history
  19. fix: show attachments on notifications too (#25443) (#25448)

    (cherry picked from commit 8e3175f)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3251586 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. perf: cap max count on list views (backport #25348) (#25463)

    * fix: dont add useless distinct clause
    
    confuses query planner in some cases
    
    (cherry picked from commit ae649aa)
    
    # Conflicts:
    #	frappe/desk/reportview.py
    
    * feat: support countig till a limit
    
    In InnoDB counting is essentially O(n) operation, it can be pretty fast
    on indexes but when filters don't use any index it usually means doing a
    full table scan.
    
    Adding a limit will stop the scan as soon as that many records are
    matched.
    
    (cherry picked from commit a49fafb)
    
    # Conflicts:
    #	frappe/desk/reportview.py
    
    * perf: show estimated count on list view
    
    (cherry picked from commit 7e88c53)
    
    * fix(UX): let user see actual count on click
    
    (cherry picked from commit fdcff2d)
    
    * fix: support child tables in count with limit
    
    (cherry picked from commit 1fa7cc7)
    
    * refactor: avoid duplicate render_count for report view
    
    Only difference is element
    
    (cherry picked from commit 698ef95)
    
    * chore: conflicts
    
    * fix: dont show tooltip if already limited (#25361)
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3bc5d8a View commit details
    Browse the repository at this point in the history
  2. feat: connect to redis sentinel for redis cache (backport #25398) (#2…

    …5449)
    
    * feat: connect to redis sentinel for redis cache (#25398)
    
    (cherry picked from commit 77618cd)
    
    # Conflicts:
    #	frappe/__init__.py
    #	frappe/utils/redis_wrapper.py
    
    * refactor: resolve conflict
    
    ---------
    
    Co-authored-by: Revant Nandgaonkar <revant.one@gmail.com>
    mergify[bot] and revant committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6ce4036 View commit details
    Browse the repository at this point in the history
  3. feat: Store printed PDF attachments on communication (backport #25439) (

    #25447)
    
    * feat: Store printed PDF attachments on communication (#25439)
    
    (cherry picked from commit e76c29f)
    
    # Conflicts:
    #	frappe/core/doctype/communication/email.py
    #	frappe/core/doctype/communication/mixins.py
    #	frappe/core/doctype/system_settings/system_settings.json
    #	frappe/core/doctype/system_settings/system_settings.py
    
    * chore: conflicts
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9b7a02f View commit details
    Browse the repository at this point in the history
  4. refactor: validate_link_and_fetch (#25185)

    Remove redundant parameters
    
    (cherry picked from commit 1f969a4)
    
    Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
    mergify[bot] and barredterra committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    65f51b6 View commit details
    Browse the repository at this point in the history
  5. fix: Skip virtual doctypes while renaming (#25473) (#25477)

    (cherry picked from commit b28db47)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c423223 View commit details
    Browse the repository at this point in the history
  6. fix: Skip virtual doctype rename for dynamic links (#25479) (#25480)

    (cherry picked from commit ce124d8)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f368236 View commit details
    Browse the repository at this point in the history
  7. fix: allow transitioning to long text (backport #25419) (#25474)

    * fix: allow transitioning to long text
    
    (cherry picked from commit 02fd017)
    
    * ci: setup ssh if test failed
    
    (cherry picked from commit 0ca0e22)
    
    # Conflicts:
    #	.github/workflows/server-tests.yml
    
    * test: fixup timeouts
    
    The tests were failing because they weren't able to complete in 20
    seconds. Ugh!
    
    (cherry picked from commit 48c24c7)
    
    # Conflicts:
    #	frappe/core/doctype/rq_job/test_rq_job.py
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    60d8c1c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. test: fix timeout decorator (#25489) (#25490)

    (cherry picked from commit 2f87a09)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    46ee40d View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. refactor: render list progressively (#25485)

    (cherry picked from commit 7781f43)
    
    Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
    mergify[bot] and barredterra committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3fae36d View commit details
    Browse the repository at this point in the history
  2. fix: escape value in multiselect pill (#25516) (#25517)

    (cherry picked from commit d7f82bc)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dbcf783 View commit details
    Browse the repository at this point in the history
  3. fix: handle distinct for fieldname (backport #25511) (#25514)

    * fix: handle distinct for fieldname (#25511)
    
    `distinct count(fieldname)` is supported well but `count(distinct fieldname)` fails if fieldname contains full field with table name included. This PR just adds basic handling for it.
    
    Needs to be rewritten entirely in QB __some day__.
    
    (cherry picked from commit 8a7beeb)
    
    # Conflicts:
    #	frappe/model/db_query.py
    #	frappe/tests/test_db_query.py
    
    * chore: conflicts
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3344df0 View commit details
    Browse the repository at this point in the history
  4. fix: escape text types before setting disp area (#25520) (#25522)

    (cherry picked from commit fa6ec99)
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e446770 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. feat: debug stuck process by sending SIGUSR1 (backport #25502) (#25526)

    * fix: debug stuck process by sending SIGUSR1
    
    It will print stack to stderr.
    
    (cherry picked from commit 6560d45)
    
    # Conflicts:
    #	frappe/__init__.py
    
    * fix: set sane default timeout on SMTP
    
    (cherry picked from commit fdd74e3)
    
    ---------
    
    Co-authored-by: Ankush Menat <ankush@frappe.io>
    mergify[bot] and ankush committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    95d1224 View commit details
    Browse the repository at this point in the history