fix: HR Settings permissions #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
approved these changes
Jun 26, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
(cherry picked from commit 6062f15) # Conflicts: # hrms/hr/doctype/hr_settings/hr_settings.json
mergify bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
(cherry picked from commit 6062f15)
ruchamahabal
pushed a commit
that referenced
this pull request
Jun 26, 2024
krantheman
added a commit
that referenced
this pull request
Jun 27, 2024
…1924 fix: HR Settings permissions (backport #1924)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives roles HR User and HR Manager 'Read' and 'Read & Write' permissions respectively for the HR Settings DocType.
The lack of these permissions causes users with these roles to get a permission error while viewing and editing Employee Checkins.