-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Performance Module (backport #43) #424
Merged
ruchamahabal
merged 71 commits into
version-14-hotfix
from
mergify/bp/version-14-hotfix/pr-43
Mar 31, 2023
Merged
feat: Performance Module (backport #43) #424
ruchamahabal
merged 71 commits into
version-14-hotfix
from
mergify/bp/version-14-hotfix/pr-43
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e36a50e)
(cherry picked from commit 38c1d90)
(cherry picked from commit 0268282)
- Details tab: basic details about appraisal cycle and employee - KRAs: table for KRA, weightage, goal completion status against the KRA and score - Feedbacks tab: add edit delete feedbacks (360 degree) (cherry picked from commit 291afb5)
- set goals, priority, update progress - link goals to appraisal cycles - goal tree: hierarchy of goals with status - update progress for goals from the tree itself (cherry picked from commit 495d086)
(cherry picked from commit 90d90b7) # Conflicts: # hrms/hr/workspace/performance/performance.json
(cherry picked from commit 1b3840c)
(cherry picked from commit 5e4b70b)
(cherry picked from commit 3b39914)
(cherry picked from commit 4765a22)
(cherry picked from commit b55d6e2)
(cherry picked from commit 229ffe1)
(cherry picked from commit 6255189)
(cherry picked from commit ef5b397)
- add details about the reviewer in performance - fix duplicate check query in appraisal (cherry picked from commit af8f577)
(cherry picked from commit d730ab2)
(cherry picked from commit eb3e0b4)
(cherry picked from commit 0fafa2b)
- rename `kra_template` to `appraisal_template` in Appraisal for consistency - whitelisted method for setting KRAs in appraisal - fix duplicate validation in appraisal - map default appraisal template while pulling employees in appraisal cycle - custom button to create or enqueue appraisal creation from Appraisal Cycle (cherry picked from commit 9eb56b3)
(cherry picked from commit dacfad2)
- set KRAs from template on server side - change naming from hash to naming series - validate duplicate appraisals before insert - remove redundant field for feedback count (cherry picked from commit fb05d3e)
(cherry picked from commit 1e3b908)
(cherry picked from commit 5eb1a39)
(cherry picked from commit 0eee782)
(cherry picked from commit adc1934)
- cleanup goal form - get kras for employee - improve treeview UX by setting more default values (cherry picked from commit 92cab7c)
(cherry picked from commit 1074174)
(cherry picked from commit 19dc040)
- added Employee Feedback Criteria master and Employee Feedback Rating child table - allow setting rating criteria in appraisal template with weights - fetch rating criteria in self appraisal and performance feedback (cherry picked from commit e2c2ee8)
(cherry picked from commit dbdf6b0)
(cherry picked from commit c37a43e)
- retain start and end date fields for backward compatibility, make them read-only - make appraisal cycle mandatory - simplify creating cycle by keeping appraisee list non-mandatory and checking it only if create appraisal is clicked (cherry picked from commit de4b7cc)
… on evaluation criteria - validate cycle's evaluation method change (cherry picked from commit 83dbe15)
- old appraisal doc has score out of 5 so conversion is required for backward compatibility (cherry picked from commit 987a0c1)
(cherry picked from commit 540cc7c)
(cherry picked from commit 2febad3)
- updating avg score in the correct appraisal becomes easier and predictable - change feedback history view to only visit feedback, remove add and edit perms (cherry picked from commit 0b373ac)
(cherry picked from commit e3a7f57)
- hide field if Appraisal Cycle is not linked since this field is irrelevant to old appraisals (cherry picked from commit 581d1b2)
(cherry picked from commit 2aba91a)
(cherry picked from commit def3fab)
(cherry picked from commit 254ff9a)
- add tree node function for goal tree - rate goals manually not getting set on client side - only calculate avg score for goals belonging to the cycle - avg feedback score not refreshed in perf view - ignore user perms for reviewer field (cherry picked from commit 9e3b135)
- validate transactions against an active cycle - validate unsubmitted appraisals (cherry picked from commit 7efbb91)
(cherry picked from commit 3ad9aa3)
[skip ci] (cherry picked from commit ea188af) # Conflicts: # hrms/hr/workspace/performance/performance.json
[skip ci] (cherry picked from commit 930d54e)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version-14-hotfix #424 +/- ##
=====================================================
+ Coverage 71.81% 72.72% +0.90%
=====================================================
Files 181 189 +8
Lines 9357 9745 +388
=====================================================
+ Hits 6720 7087 +367
- Misses 2637 2658 +21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #43 done by Mergify.
Cherry-pick of 90d90b7 has failed:
Cherry-pick of 468453b has failed:
Cherry-pick of 404ee15 has failed:
Cherry-pick of ea188af has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com