Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patch): run payroll entry status patch for null status only #431

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Apr 4, 2023

Closes: #395

Membership check fails for null values in status column. Instead of checking if status is not in a particular list, directly apply update query for rows where status is null

Re-run the post install patch to update status for existing payroll entries

@ruchamahabal ruchamahabal merged commit 5793097 into frappe:develop Apr 4, 2023
mergify bot pushed a commit that referenced this pull request Apr 4, 2023
ruchamahabal added a commit that referenced this pull request Apr 4, 2023
…port #431) (#432)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
ruchamahabal added a commit that referenced this pull request Apr 6, 2023
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fix: format currency/float as per number format in work history (backport #429) (#430)
fix(patch): run payroll entry status patch for null status only (backport #431) (#432)
fix: scroll to error message on payroll entry failure (backport #433) (#434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status of Payroll Entry becomes "null" after migration
1 participant