Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention returning undefined in "Finders Keepers" #11476

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Mention returning undefined in "Finders Keepers" #11476

merged 1 commit into from
Oct 31, 2016

Conversation

Kwpolska
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes. [is that really necessary for a simple text change? considering how hard the setup is?]

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

The "Finders Kepeers" challenge text does not mention the need to return undefined if no element passes the truth test. Therefore, students can’t do it without checking the challenge tests.

The "Finders Kepeers" challenge text does not mention the need to return `undefined` if no element passes the truth test. Therefore, students can’t do it without checking the challenge tests.
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 31, 2016
@Bouncey
Copy link
Member

Bouncey commented Oct 31, 2016

@Kwpolska Thanks for the PR 👍

Can you point me in the direction of the original issue please?

@Kwpolska
Copy link
Contributor Author

What original issue? (I didn’t create any GitHub issues if that’s what you ask.)

@Bouncey
Copy link
Member

Bouncey commented Oct 31, 2016

LGTM 👍

Thanks for contributing 🎉

@Bouncey Bouncey merged commit 057801a into freeCodeCamp:staging Oct 31, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 31, 2016
@Kwpolska Kwpolska deleted the fix/finders-keepers-undefined branch October 31, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants