-
-
Notifications
You must be signed in to change notification settings - Fork 38k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention returning undefined in "Finders Keepers" #11476
Merged
Bouncey
merged 1 commit into
freeCodeCamp:staging
from
Kwpolska:fix/finders-keepers-undefined
Oct 31, 2016
Merged
Mention returning undefined in "Finders Keepers" #11476
Bouncey
merged 1 commit into
freeCodeCamp:staging
from
Kwpolska:fix/finders-keepers-undefined
Oct 31, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Finders Kepeers" challenge text does not mention the need to return `undefined` if no element passes the truth test. Therefore, students can’t do it without checking the challenge tests.
BerkeleyTrue
added
the
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
label
Oct 31, 2016
@Kwpolska Thanks for the PR 👍 Can you point me in the direction of the original issue please? |
What original issue? (I didn’t create any GitHub issues if that’s what you ask.) |
LGTM 👍Thanks for contributing 🎉 |
BerkeleyTrue
removed
the
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
label
Oct 31, 2016
This was referenced Dec 15, 2021
This was referenced May 13, 2022
This was referenced May 22, 2023
This was referenced Jun 21, 2023
This was referenced Oct 2, 2023
This was referenced Jan 9, 2024
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
staging
branch of FreeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes. [is that really necessary for a simple text change? considering how hard the setup is?]Type of Change
Checklist:
Description
The "Finders Kepeers" challenge text does not mention the need to return
undefined
if no element passes the truth test. Therefore, students can’t do it without checking the challenge tests.