Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammatical errors in chain-middleware-to-create-a-time-server.spanish.md #36949

Closed
wants to merge 1 commit into from

Conversation

luisignaciocc
Copy link
Contributor

Fixed some grammatical errors

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2019

@scissorsneedfoodtoo scissorsneedfoodtoo added language: Spanish scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Oct 2, 2019
@@ -1,17 +1,17 @@
---
id: 587d7fb1367417b2b2512bf4
title: Chain Middleware to Create a Time Server
localeTitle: Cadena de middleware para crear un servidor de tiempo
localeTitle: Encadena un middleware para crear un servidor de tiempo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Middleware is plural, chaining means connecting several between themselves.

challengeType: 2
---

## Description
<section id='description'>
Middleware puede montarse en una ruta específica usando <code>app.METHOD(path, middlewareFunction)</code> . Middleware también puede ser encadenado dentro de la definición de ruta.
un Middleware puede montarse en una ruta específica usando <code>app.METHOD(path, middlewareFunction)</code> . Los Middlewares también pueden ser encadenados dentro de la definición de ruta.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
un Middleware puede montarse en una ruta específica usando <code>app.METHOD(path, middlewareFunction)</code> . Los Middlewares también pueden ser encadenados dentro de la definición de ruta.
Un Middleware puede montarse en una ruta específica usando <code>app.METHOD(path, middlewareFunction)</code> . Los Middlewares también pueden ser encadenados dentro de la definición de ruta.

But more importantly, should middleware really be capitalized? Now it's not consistent in the challenge any more.

@RandellDawson
Copy link
Member

Hi @NachoCoding

As there has been no response from your end for a while, we are closing this PR.

Feel free to request this PR to be reopened or create a new PR, if you still wish to make the changes you originally added plus any additional change requests asked of you. Also, remember to update your fork, so you have the latest version of master in case it has changed significantly.

Happy Coding!

@RandellDawson RandellDawson added the other: decayed Stale issues that need follow up from commentators. Were closed for inactivity label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other: decayed Stale issues that need follow up from commentators. Were closed for inactivity scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants