-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape image in case of url String #21
Escape image in case of url String #21
Conversation
@freearhey Hey, could this be reviewed when you have the time? Thank you for your work! Some more context for the PR: Example: <programme start="20241106223500 +0000" stop="20241107011500 +0000" channel="Lorem Ipsum"><title lang="en">Lorem Ipsum</title><image>https://example.com/example?foo=foo&bar=bar</image></programme>
|
@RubenTeixeira Taking a further look at your patch, I think you should change change this line to call Line 178 in 5494988
e.g. [escapeString(image.value)] And since you're at it, do the same for It's probably a good idea to update the tests as well: https://github.com/freearhey/epg-grabber/blob/5494988b3674508c51ffcdae76de4034ac79ef7d/tests/xmltv.test.js Let me know if you want me to open another PR instead, in case you're busy. |
Fixed in |
@freearhey any chance of updating this in https://github.com/iptv-org/epg? Thanks in advance |
This fixes an issue with image URLs not being escaped and therefore resulting in invalid XML. See freearhey/epg-grabber#21
This fixes an issue with image URLs not being escaped and therefore resulting in invalid XML. See freearhey/epg-grabber#21
This fixes an issue with image URLs not being escaped and therefore resulting in invalid XML. See freearhey/epg-grabber#21
No description provided.