Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update check does not place "Check for updates" checkmark in UI #513

Closed
eloquence opened this issue Aug 10, 2023 · 1 comment · Fixed by #515
Closed

Update check does not place "Check for updates" checkmark in UI #513

eloquence opened this issue Aug 10, 2023 · 1 comment · Fixed by #515
Assignees
@deeplow
Labels
bug Something isn't working ux
Milestone
0.5.0

Comments

@eloquence
Copy link
Member

Steps to reproduce

  1. On a Mac, install and run Dangerzone so you get the update check prompt.
  2. Confirm that you want automatic update checks.
  3. Click the menu button to reveal the current state of the "update check" settings.

Expected behavior

Update check should have a checkmark next to it, since I've enabled update checks

Actual behavior

Checkmark is not set until I restart Dangerzone
@eloquence eloquence added the bug Something isn't working label Aug 10, 2023
@eloquence eloquence changed the title Update check does not place "Check for updates" checkmark Update check does not place "Check for updates" checkmark in UI Aug 10, 2023
@deeplow deeplow added the ux label Aug 14, 2023
@deeplow deeplow assigned deeplow and unassigned deeplow Aug 14, 2023
deeplow added a commit that referenced this issue Aug 14, 2023
@deeplow
Propagate "update check" prompt to UI checkbox
f1e2e3f 
The "check for updates" button wasn't showing up immediately as checked
as soon as the user is prompted for checking updates. This fixes that.

Fixes #513
@deeplow
Copy link
Contributor

deeplow commented Aug 14, 2023

Thanks for spotting this. I can confirm the bug. I have a working fix.

deeplow added a commit that referenced this issue Aug 14, 2023
@deeplow
Propagate "update check" prompt to UI checkbox
3915a86 
The "check for updates" button wasn't showing up immediately as checked
as soon as the user is prompted for checking updates. This fixes that.

Fixes #513
@deeplow deeplow mentioned this issue Aug 14, 2023
Merged
@apyrgio apyrgio added this to the 0.5.0 milestone Aug 22, 2023
deeplow added a commit that referenced this issue Oct 18, 2023
@deeplow
CHANGELOG: Fix issue #513 description
e93fdc3
@deeplow deeplow mentioned this issue Oct 18, 2023
Merged
deeplow added a commit that referenced this issue Oct 19, 2023
@deeplow
CHANGELOG: Fix issue #513 description
a89c496
deeplow added a commit that referenced this issue Oct 19, 2023
@deeplow
CHANGELOG: Fix issue #513 description
0aeef1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeplow deeplow

Labels
bug Something isn't working ux
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Propagate "update check" prompt to UI checkbox freedomofpress/dangerzone
3 participants
@eloquence @apyrgio @deeplow