-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate "update check" prompt to UI checkbox #515
Conversation
@apyrgio I was not sure what the best state propagation method was. I opted for sending a "refresh" signal, but the state is written to and read from the settings. We could do that through the signal and it would also be fine, especially since this is an edge case and we don't need to keep track of that propagated state (like the |
@apyrgio that's way more elegant. Let's go with that. I haven't made a test, though since I didn't find a decent place to go a test for this. Since the behavior only really happens in |
Hm, you're right, there's no easy way to test it. Given that it's a one line thing, maybe we can just test it manually. |
Anything else missing @apyrgio? |
Nope, just checked it manually as well, and it seems to work. Feel free to merge it with just the latest commit. |
c6368f8
to
8ae88eb
Compare
The "check for updates" button wasn't showing up immediately as checked as soon as the user is prompted for checking updates. This fixes that.
Fixes #513