Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate usage of X-Download-Options header #6180

Closed
Tracked by #6186
evilaliv3 opened this issue Nov 21, 2021 · 2 comments
Closed
Tracked by #6186

Deprecate usage of X-Download-Options header #6180

evilaliv3 opened this issue Nov 21, 2021 · 2 comments

Comments

@evilaliv3
Copy link
Contributor

With this ticket I would like to propose the deprecation of the usage of the X-Download-Options header that was actually supported only by IE and introduced in IE8 to fix their own broken download implementation.

Any up to date browser, including IE and Edge now does safely implement the noopen policy on file download while using the standard header Content-Disposition: attachment: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

Considering that we do not target any IE browser (expecially IE 8 o IE9) we could safely remove the header that represents just an overhead.

This ticket follows the same evaluation applied to the GlobaLeaks project: globaleaks/globaleaks-whistleblowing-software@8c1af7f

@zenmonkeykstop
Copy link
Contributor

Content-disposition: attachment is indeed being set as expected. This will be folded into a new PR along with other header changes, as per #6183 (comment)

conorsch pushed a commit that referenced this issue Dec 9, 2021
conorsch pushed a commit that referenced this issue Dec 9, 2021
@zenmonkeykstop
Copy link
Contributor

Closed by #6187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants