fix: remove unreliable :has() selector in InnerWrapper #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
renejfc
approved these changes
Aug 5, 2025
dornelasnelson
approved these changes
Aug 5, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
### [2.41.2](v2.41.1...v2.41.2) (2025-08-05) ### Bug Fixes * remove unreliable :has() selector in InnerWrapper ([#553](#553)) ([1ca4f8c](1ca4f8c))
|
🎉 This PR is included in version 2.41.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed the CSS
:has()selector in theInnerWrappercomponent that was incorrectly applying padding even when labels were visually hidden, and the label is required anyways.Why
The
:has()selector was detecting theLabelcomponent even when they were wrapped inVisuallyHidden, causing padding to be applied incorrectly. This resulted in unwanted space at the top of components with hidden labels.We now rely solely on the prop-based conditional styling (
$hideLabel), which provides more predictable and consistent behavior across all browsers.