Parse and store specials with unique ptr #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbenage-cx
added
category:refactoring
|
@dbenage-cx I can confirm that this works on Fedora with Boost v1.63. |
dbenage-cx
force-pushed
the
fix_1546-unique_ptr-specals_parser
branch
from
f20295a
to
a70904e
Compare
|
1.63 introduces variadic templates, the same results can be seen by defining I was not able to determine the correct macros and order to increase number of args. |
parse/SpecialsParser.cpp
Outdated
| } | ||
| #endif | ||
|
|
||
| namespace { | ||
| const boost::phoenix::function<parse::detail::is_unique> is_unique_; | ||
|
|
||
| const boost::phoenix::function<parse::detail::insert> insert_; | ||
| struct special_pod { | ||
| special_pod (std::string name_, |
|
otherwise looks fine |
dbenage-cx
force-pushed
the
fix_1546-unique_ptr-specals_parser
branch
from
a70904e
to
6e9e4ee
Compare
dbenage-cx
removed
the
status:work in progress
dbenage-cx
added
the
status:merged
This was referenced Oct 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On local system, compiling with boost v1.62 or lower fails(1.63+ is ok), opening PR for CI results to help troubleshoot
Resolves #1546