Update src does not work

[Andries-Smit]

Thanks for this solution.

An improvement is to support updating the src attribute. At the moment it does not update the bg image url when the src is updated.

https://github.com/bfred-it/object-fit-images/blob/master/index.js#L118
By swapping the src and the currentSrc fixed it for me.
el.style.backgroundImage = "url(\"" + ((ofi.img.src || ofi.img.currentSrc).replace(/"/g, '\\"')) + "\")";

Though I cant oversee the full effect. #84

Cheers.

[fregante]

At the moment it does not update the bg image url when the src is updated.

Are you using only src or srcset in your tests? Can you provide a jsfiddle showing the issue?

[Andries-Smit]

Thanks for the quick response

https://jsbin.com/goxazineti/1/edit?html,output

• run in Chome the cat will be updated gray to ginger
• run in IE you keep the gray cat.

If you dont like cats i could replace the images with dogs,.

[fregante]

No, I like cats 🙀

[alejandroiglesias]

Any updates on this? I can confirm this issue on Edge.

[fregante]

Sorry it took so long. Yeah the bug is confirmed, however that is not the only way to change the src.

Changing the src property instead works and it's always the preferred method:

img.src = "new=image.jpg";

https://jsbin.com/gipuzolumo/edit?html,output

[alejandroiglesias]

@bfred-it thing is I'm using Angular.js and the ng-src attribute directive, which sets the src attribute once the object data is available.

[benmccallum]

I'm doing a simple lazy-load, setting the src to the real image (from a spacer image) as the user scrolls down and getting this too. Had to manually call objectFitImages(myImages) again.