Run anywhere #3
Run anywhere #3
Conversation
| @@ -22,16 +16,25 @@ async function run() { | |||
| const {stdout: t} = await execFile('git', ['tag', '-l', '--sort=-creatordate']); | |||
| const tags = t.split('\n').filter(Boolean).map(tag => tag.trim()); | |||
|
|
|||
| if (tags.length === 0) { | |||
There was a problem hiding this comment.
Currently it doesn't seem to support creating a release for the first tag (which is usually just "Initial release"), so this condition should reflect that, at least for the time being.
| if (tags.length === 0) { | |
| if (tags.length < 2) { |
There was a problem hiding this comment.
This is unchanged. Did you add support for "initial release" in the commit?
There was a problem hiding this comment.
Support for "initial release" has been there the whole time.
If there is only one tag, then we compare that with the root commit (initial commit) we can find.
There was a problem hiding this comment.
I'd prefer this to be just Initial release but that works too, for the time being
|
Looks good, but can test this PR on refined-github/refined-github#3421, refined-github/github-url-detection#30 or fregante/browser-extension-template#37? So we're sure it works the way we want it to work. |
|
Will try this on fregante/browser-extension-template#37, as that looks like the best place to test this stuff without polluting other repositories. |
| @@ -66,7 +72,7 @@ async function run() { | |||
| releaseBody.push(`\n[\`${range}\`](https://github.com/${owner}/${repo}/compare/${range})`); | |||
| } | |||
|
|
|||
| const octokit = getOctokit(process.env.RELEASE_TOKEN); | |||
| const octokit = getOctokit(core.getInput('token')); | |||
There was a problem hiding this comment.
You can use this package to automatically pickup the token: https://github.com/octokit/action.js
The readme doesn’t show with.token support but I just added it in a dependency: octokit/auth-action.js#106
There was a problem hiding this comment.
That sounds cool, do you want me to add this to #22?
Closes #1
ENV