-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: Keep output artifacts when rebuilding #198
base: next
Are you sure you want to change the base?
Conversation
When doing a new build or a rebuild, all previous artifacts are deleted even if the new build fails. Replacing mv with rsync allows preserving old artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't like this - just complicates things, if old build artifacts are kept. You can no longer distinguish, whether they are from the current or last build, whether they include your latest change or they don't.
If you want to keep old build output, make a local script to copy them somewhere else.
Each build has both a timestamp as well as it uses the git hash in its name. I don't see how you be struggling to distinguish new and old builds, when builds take always more than a few minutes. In case of identical names, successful builds will overwrite existing artifacts. If a build failed, you would be able to see it both in the log messages, the return code or the timestamp of the last build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seriously, I think this is wrong. I don't want to keep old build output. If you really want this, hide it behind a build option and keep the default as is.
in Aachen we use environment variables now and only have one output folder for Gluon instead. we set
https://gluon.readthedocs.io/en/latest/user/getting_started.html also we have a different output folder, for when we build single devices now:
(we stop output-clean, when GLUON_DEVICES is set) |
@grische what do you think? |
When doing a new build or a rebuild, all previous artifacts are deleted even if the new build fails. Replacing mv with rsync allows preserving previous artifacts.