Add forward slash to the list of characters to sanitize in sanitize_name #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please read the comment block starting the function your are modifying. It both contains an explanation for why your patch is the wrong solution and what the right solution to the problem which triggered your PR is. Besides that, |
|
Oh! I'm embarrassed to have glossed right over that comment in the sources. Thanks for explaining so patiently. |
Closed
|
:) "live and learn" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #32, I believe this is the correct fix for the underlying issue causing that import failure, or at least it addresses one of the possible branch naming problems that could lead to the issue.