Add Date minimum/maximum constraints #57
Conversation
schema/datetime.go
Outdated
| func decodeDate(format, value string, c Constraints) (time.Time, error) { | ||
| y, err := decodeDateWithoutChecks(format, value) | ||
| if err != nil { | ||
| return time.Now(), err |
There was a problem hiding this comment.
Could you please return v here? This was discussed and changed #54,
schema/datetime.go
Outdated
| if c.Maximum != "" { | ||
| max, err = decodeDateWithoutChecks(format, c.Maximum) | ||
| if err != nil { | ||
| return time.Now(), err |
There was a problem hiding this comment.
Same above. Please return max.
schema/datetime.go
Outdated
| if c.Minimum != "" { | ||
| min, err = decodeDateWithoutChecks(format, c.Minimum) | ||
| if err != nil { | ||
| return time.Now(), err |
There was a problem hiding this comment.
Same above, please return min, err
|
@danielfireman I'm following same patterns in the codebase, however, there are some things that I don't quite understand. Why is it that the test does assertions against private functions? Wouldn't be better to use |
Rename castDate to be decodeDateWithoutChecks to follow similar pattern as the decodeYearMonthWithoutChecks function.
cored
force-pushed
the
add-date-min-max-constraint
branch
from
f2ecb50
to
1d175fb
Compare
|
Hi @cored, thanks for your contributions! About your question:
As the code gets more complex, it is usually better to rely more heavily on unit testing. There are many reasons for that, including easier maintenance, faster, simpler (more benefits here). Let's say we decide to test that against the public Field.Decode. That simple test would involve: i) creating a field as a string, ii) call |
for issue #44