Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

producer_args is deprecated #77

Closed
KES777 opened this issue Apr 6, 2023 · 2 comments
Closed

producer_args is deprecated #77

KES777 opened this issue Apr 6, 2023 · 2 comments

Comments

@KES777
Copy link

KES777 commented Apr 6, 2023

SQL::Translator::Diff::schema_diff(): producer_args is deprecated -- it does not go straight to the producer, it goes to the internal sqlt object. Please use sqlt_args, which reflects how it's used at DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator.pm line 533

https://github.com/dbsrgits/sql-translator/blob/master/Changes#L4

Just a small renaming.

@rabbiveesh
Copy link

Yeah, i meant to open this ticket before I released, sorry about that

paultcochrane added a commit to paultcochrane/DBIx-Class-DeploymentHandler that referenced this issue Jul 17, 2024
As of [`SQL::Translator` version
1.63](https://github.com/dbsrgits/sql-translator/blob/master/Changes),
the `producer_args` option has been renamed to `sqlt_args`.  Code still
using `producer_args` now generates this deprecation warning:

```
SQL::Translator::Diff::schema_diff(): producer_args is deprecated -- it does
not go straight to the producer, it goes to the internal sqlt object.
Please use sqlt_args, which reflects how it's used at
..../DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator.pm line 533
```

This commit updates the code to use the new option name, thus removing
the deprecation warning, and hence resolving the issue mentioned in frioux#77.
wesQ3 pushed a commit that referenced this issue Jul 17, 2024
As of [`SQL::Translator` version
1.63](https://github.com/dbsrgits/sql-translator/blob/master/Changes),
the `producer_args` option has been renamed to `sqlt_args`.  Code still
using `producer_args` now generates this deprecation warning:

```
SQL::Translator::Diff::schema_diff(): producer_args is deprecated -- it does
not go straight to the producer, it goes to the internal sqlt object.
Please use sqlt_args, which reflects how it's used at
..../DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator.pm line 533
```

This commit updates the code to use the new option name, thus removing
the deprecation warning, and hence resolving the issue mentioned in #77.
wesQ3 added a commit that referenced this issue Jul 17, 2024
 - Fix SQL::Translator producer_args deprecation warning #77 - thanks
   @paultcochrane
@wesQ3
Copy link
Collaborator

wesQ3 commented Jul 17, 2024

Fixed in v0.002234

@wesQ3 wesQ3 closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants