Skip to content

Update README.md #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2019
Merged

Update README.md #493

merged 1 commit into from
Nov 10, 2019

Conversation

dotku
Copy link
Contributor

@dotku dotku commented Jun 4, 2019

create a better sample that make sense

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.579% when pulling 7946c18 on dotku:patch-2 into c87715a on frontend-collective:master.

wuweiweiwu
wuweiweiwu reviewed Jul 25, 2019
View reviewed changes
Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate how this makes the example better?

wuweiweiwu
wuweiweiwu approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@wuweiweiwu wuweiweiwu merged commit 73aee4a into frontend-collective:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotku @coveralls @wuweiweiwu