Adding visual testing

[hannah]

Hi everyone!

I saw that you all were using Storybook, and thought that adding some visual testing would be helpful!

In case you aren't familiar, automated visual regression testing compares visual differences in a human readable manner, instead of comparing pixel by pixel as a machine would do. It's reflective of how a user will experience a website. The Storybook documentation has a pretty comprehensive overview of visual regression testing as a whole, and how it applies to React projects in particular.

Since Storybook is already installed in this project, adding automated visual regression testing was a simple task.

Applitools provides an SDK that makes testing easy. In order to run it, you need is to sign up for an Applitools account and add the key to your local environment. I’ve added test:visual as an alias that fits the current testing shortcuts in the command line.

Applitools has a decent limit for their free tier accounts, but they also provide open source projects with free unlimited accounts if you contact them.

[coveralls]

Coverage remained the same at 75.579% when pulling 1f78280 on hannah:add-visual-testing into c87715a on frontend-collective:master.

[wuweiweiwu]

thanks for doing this! this is awesome! however, there is a small issue. I want this to run on ci on pull requests. but travis ci has some limitations on environment variable not being able to be accessed by builds on fork pull requests

see frontend-collective/react-image-lightbox#177 (comment)

[cmwhited]

Hey @wuweiweiwu any luck with the TravisCI issue for this?

[cmwhited]

Hey @wuweiweiwu, looks like this PR is passing all checks and is g2g. Can we go ahead and merge this in?

cc @hannah

[cmwhited]

Hey @wuweiweiwu pinging again to bring this to your attention. It is good to merge, is everything g2g on your end?

[cmwhited]

@wuweiweiwu have you had a chance to look at this? Would love to get this merged ASAP

[cmwhited]

@wuweiweiwu just pinging again on this.

[cmwhited]

@wuweiweiwu another ping. would love to get eyes on this.

[cmwhited]

@wuweiweiwu @tiff another ping hoping to see if y'all have had a chance to take a look at this

[cmwhited]

@wuweiweiwu @tiff any luck with the Travis CI issue or had a chance to look into this?

[cmwhited]

@wuweiweiwu @tiff any chance y'all can take a look and get some eyes on this? Would love to get it merged.

[cmwhited]

@wuweiweiwu still looking to get this merged. any chance you have looked at this PR?

[cmwhited]

@wuweiweiwu pinging again. thanks!

[AndrewKiri]

This is crazy.... This repo is forsaken by maintainers...

[lifejuggler]

while this is nice to have, I think there are more critical issues that needs to be worked out in this repo, so i didn't do anything about it.