Skip to content

Conversation

florianf
Copy link

@florianf florianf commented Apr 1, 2020

Hi,

currently the prevTreeIndex, nextTreeIndex indices in the canDrop callback are wrong when nodes are expanded during the dragging operation (hovering over closed node). The changes are internally reflected in the treeData structure, but not yet published (via onChange or onVisibilityToggle). This breaks all invocations of getVisibleNodeInfoAtIndex when using f.ex. nextTreeIndex.

To mitigate the issue, the current treeData structure is passed to the canDrop callback.

Thanks for your work!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.492% when pulling 1dfbab1 on florianf:master into d55561e on frontend-collective:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants