Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up builds #1626

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Speed up builds #1626

merged 4 commits into from
Mar 7, 2024

Conversation

eeeqeee
Copy link
Collaborator

@eeeqeee eeeqeee commented Mar 6, 2024

Describe your changes

Vite pulls from the source when building frontend, so these extra build steps are unnecessary

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited

[sr-frontend] [Wed Mar 6 04:15:57 UTC 2024] - Deployed d2cebec to https://genshin-optimizer-prs.github.io/pr/1626/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Mar 6 04:16:59 UTC 2024] - Deployed d2cebec to https://genshin-optimizer-prs.github.io/pr/1626/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Mar 6 21:56:02 UTC 2024] - Deployed 0e74009 to https://genshin-optimizer-prs.github.io/pr/1626/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Mar 6 22:08:29 UTC 2024] - Deployed fc3a7d8 to https://genshin-optimizer-prs.github.io/pr/1626/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Mar 6 22:09:30 UTC 2024] - Deployed fc3a7d8 to https://genshin-optimizer-prs.github.io/pr/1626/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Mar 6 22:15:20 UTC 2024] - Deployed f665367 to https://genshin-optimizer-prs.github.io/pr/1626/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Mar 6 22:16:36 UTC 2024] - Deployed f665367 to https://genshin-optimizer-prs.github.io/pr/1626/frontend (Takes 3-5 minutes after this completes to be available)

[Thu Mar 7 23:45:03 UTC 2024] - Deleted deployment

frzyc
frzyc reviewed Mar 6, 2024
View reviewed changes
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, since we are not building these libs stand-alone, we probably don't even need any build targets on them in the 1st place.

@eeeqeee eeeqeee requested a review from frzyc March 6, 2024 22:24
@eeeqeee eeeqeee merged commit a4833bc into master Mar 7, 2024
6 checks passed
@eeeqeee eeeqeee deleted the eeeqeee/fast-build branch March 7, 2024 23:44
nguyentvan7 pushed a commit that referenced this pull request Mar 12, 2024
@frzyc @eeeqeee @HassnHamada
Frzyc/go/simplify opt (#1666)
ca73f9f 
* Condense characters page (#1621)

* fix null checks (#1624)

* Cache more actions (#1622)

* cache more

* Add comment

* Speed up builds (#1626)

* drop unnecessary deps

* remove almost all build steps

why doesnt json have trailing commas :(

* rm build steps from sr

* make equipped build title button-like (#1629)

* make equipped build title button-like

* format

* make build TC title more button-like

* only deploy if build was a success (#1633)

* Create PRs in `new-release.yml` (#1631)

* yep

* fixes

* allow squash merges

* fix typo

* typo2

* printf

* Convert Pagination to infinite scroll (#1627)

* Infinite scroll experiment on artifacts page

* convert all pagination to infinite scroll

* add inf scroll to art exclusion

* fix typecheck in mini-ci (#1636)

* fix typecheck in mini-ci

* typecheck first

* move teambuff to team overview (#1632)

* move teambuff to team overview

* update team button to settings icon

* non full-width add button

* Add teams page filter (#1639)

* Add teams page filter

* format

* additional features

* fix translation

* Add `teams` tab to mobile UI (#1654)

* Update teamcard (#1653)

* update teamcard

* remove unnecessary divider

* more colorful teammate selector

* update migration naming (#1658)

* update migration naming

* add migration for GO migration on import

* Open Team Editor after creating team from character editor (#1655)

* Open Team Editor after creating team from character editor

* remove console.log

* Show loadout + build name on teamcard hover (#1656)

* show loadout + build name on teamcard hover

* update teamcard

* fix team navigation (#1659)

* Combine Loadout and Build settings into a singular popup (#1662)

* fix SetEffectDisplay

* fix build

---------

Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com>
Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
nguyentvan7 added a commit that referenced this pull request Mar 12, 2024
@nguyentvan7 @frzyc
@eeeqeee @HassnHamada
Frzyc/go/simplify opt (#1669)
4c566b8 
* Condense characters page (#1621)

* fix null checks (#1624)

* Cache more actions (#1622)

* cache more

* Add comment

* Speed up builds (#1626)

* drop unnecessary deps

* remove almost all build steps

why doesnt json have trailing commas :(

* rm build steps from sr

* make equipped build title button-like (#1629)

* make equipped build title button-like

* format

* make build TC title more button-like

* only deploy if build was a success (#1633)

* Create PRs in `new-release.yml` (#1631)

* yep

* fixes

* allow squash merges

* fix typo

* typo2

* printf

* Convert Pagination to infinite scroll (#1627)

* Infinite scroll experiment on artifacts page

* convert all pagination to infinite scroll

* add inf scroll to art exclusion

* fix typecheck in mini-ci (#1636)

* fix typecheck in mini-ci

* typecheck first

* move teambuff to team overview (#1632)

* move teambuff to team overview

* update team button to settings icon

* non full-width add button

* Add teams page filter (#1639)

* Add teams page filter

* format

* additional features

* fix translation

* Add `teams` tab to mobile UI (#1654)

* Update teamcard (#1653)

* update teamcard

* remove unnecessary divider

* more colorful teammate selector

* update migration naming (#1658)

* update migration naming

* add migration for GO migration on import

* Open Team Editor after creating team from character editor (#1655)

* Open Team Editor after creating team from character editor

* remove console.log

* Show loadout + build name on teamcard hover (#1656)

* show loadout + build name on teamcard hover

* update teamcard

* fix team navigation (#1659)

* Combine Loadout and Build settings into a singular popup (#1662)

* fix SetEffectDisplay

* fix build

---------

Co-authored-by: frzyc <frzyc@users.noreply.github.com>
Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com>
Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
RobberToe added a commit to RobberToe/genshin-optimizer that referenced this pull request Mar 13, 2024
@RobberToe
Revert "Speed up builds (frzyc#1626)"
7d1faa9 
This reverts commit a4833bc.
@nguyentvan7 nguyentvan7 mentioned this pull request May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzyc frzyc frzyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eeeqeee @frzyc