Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teamcard #1653

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Update teamcard #1653

merged 4 commits into from
Mar 11, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Mar 10, 2024

Describe your changes

  • Update the Team card with new gradient based on teammate element
  • Allow team card title to be clickable
  • Move non-essential buttons to Team editor
  • Update the Teammate selector with color
image image image

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Mar 10, 2024

[sr-frontend] [Sun Mar 10 02:23:51 UTC 2024] - Deployed ef36473 to https://genshin-optimizer-prs.github.io/pr/1653/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Mar 10 02:24:43 UTC 2024] - Deployed ef36473 to https://genshin-optimizer-prs.github.io/pr/1653/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Mar 10 02:32:37 UTC 2024] - Deployed 207fbb9 to https://genshin-optimizer-prs.github.io/pr/1653/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Mar 10 02:33:44 UTC 2024] - Deployed 207fbb9 to https://genshin-optimizer-prs.github.io/pr/1653/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Mar 10 05:10:14 UTC 2024] - Deployed 663fc96 to https://genshin-optimizer-prs.github.io/pr/1653/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Mar 10 05:12:15 UTC 2024] - Deployed 663fc96 to https://genshin-optimizer-prs.github.io/pr/1653/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sun Mar 10 09:04:34 UTC 2024] - Deployed f27e2d8 to https://genshin-optimizer-prs.github.io/pr/1653/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Mar 10 09:05:07 UTC 2024] - Deployed f27e2d8 to https://genshin-optimizer-prs.github.io/pr/1653/frontend (Takes 3-5 minutes after this completes to be available)

[Mon Mar 11 02:30:03 UTC 2024] - Deleted deployment

@frzyc frzyc merged commit 146fee5 into master Mar 11, 2024
6 checks passed
@frzyc frzyc deleted the teamcard_update branch March 11, 2024 02:29
nguyentvan7 pushed a commit that referenced this pull request Mar 12, 2024
* Condense characters page (#1621)

* fix null checks (#1624)

* Cache more actions (#1622)

* cache more

* Add comment

* Speed up builds (#1626)

* drop unnecessary deps

* remove almost all build steps

why doesnt json have trailing commas :(

* rm build steps from sr

* make equipped build title button-like (#1629)

* make equipped build title button-like

* format

* make build TC title more button-like

* only deploy if build was a success (#1633)

* Create PRs in `new-release.yml` (#1631)

* yep

* fixes

* allow squash merges

* fix typo

* typo2

* printf

* Convert Pagination to infinite scroll (#1627)

* Infinite scroll experiment on artifacts page

* convert all pagination to infinite scroll

* add inf scroll to art exclusion

* fix typecheck in mini-ci (#1636)

* fix typecheck in mini-ci

* typecheck first

* move teambuff to team overview (#1632)

* move teambuff to team overview

* update team button to settings icon

* non full-width add button

* Add teams page filter (#1639)

* Add teams page filter

* format

* additional features

* fix translation

* Add `teams` tab to mobile UI (#1654)

* Update teamcard (#1653)

* update teamcard

* remove unnecessary divider

* more colorful teammate selector

* update migration naming (#1658)

* update migration naming

* add migration for GO migration on import

* Open Team Editor after creating team from character editor (#1655)

* Open Team Editor after creating team from character editor

* remove console.log

* Show loadout + build name on teamcard hover (#1656)

* show loadout + build name on teamcard hover

* update teamcard

* fix team navigation (#1659)

* Combine Loadout and Build settings into a singular popup (#1662)

* fix SetEffectDisplay

* fix build

---------

Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com>
Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
nguyentvan7 added a commit that referenced this pull request Mar 12, 2024
* Condense characters page (#1621)

* fix null checks (#1624)

* Cache more actions (#1622)

* cache more

* Add comment

* Speed up builds (#1626)

* drop unnecessary deps

* remove almost all build steps

why doesnt json have trailing commas :(

* rm build steps from sr

* make equipped build title button-like (#1629)

* make equipped build title button-like

* format

* make build TC title more button-like

* only deploy if build was a success (#1633)

* Create PRs in `new-release.yml` (#1631)

* yep

* fixes

* allow squash merges

* fix typo

* typo2

* printf

* Convert Pagination to infinite scroll (#1627)

* Infinite scroll experiment on artifacts page

* convert all pagination to infinite scroll

* add inf scroll to art exclusion

* fix typecheck in mini-ci (#1636)

* fix typecheck in mini-ci

* typecheck first

* move teambuff to team overview (#1632)

* move teambuff to team overview

* update team button to settings icon

* non full-width add button

* Add teams page filter (#1639)

* Add teams page filter

* format

* additional features

* fix translation

* Add `teams` tab to mobile UI (#1654)

* Update teamcard (#1653)

* update teamcard

* remove unnecessary divider

* more colorful teammate selector

* update migration naming (#1658)

* update migration naming

* add migration for GO migration on import

* Open Team Editor after creating team from character editor (#1655)

* Open Team Editor after creating team from character editor

* remove console.log

* Show loadout + build name on teamcard hover (#1656)

* show loadout + build name on teamcard hover

* update teamcard

* fix team navigation (#1659)

* Combine Loadout and Build settings into a singular popup (#1662)

* fix SetEffectDisplay

* fix build

---------

Co-authored-by: frzyc <frzyc@users.noreply.github.com>
Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com>
Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
RobberToe added a commit to RobberToe/genshin-optimizer that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow clicking the title space of team card Add element context to team card
2 participants