move teambuff to team overview #1632
Conversation
|
[sr-frontend] [Fri Mar 8 01:55:48 UTC 2024] - Deployed bce1e66 to https://genshin-optimizer-prs.github.io/pr/1632/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Mar 8 01:57:26 UTC 2024] - Deployed bce1e66 to https://genshin-optimizer-prs.github.io/pr/1632/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Fri Mar 8 08:38:24 UTC 2024] - Deployed 85cad82 to https://genshin-optimizer-prs.github.io/pr/1632/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Mar 8 08:39:14 UTC 2024] - Deployed 85cad82 to https://genshin-optimizer-prs.github.io/pr/1632/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sat Mar 9 07:34:49 UTC 2024] - Deployed 257282d to https://genshin-optimizer-prs.github.io/pr/1632/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat Mar 9 07:35:29 UTC 2024] - Deployed 257282d to https://genshin-optimizer-prs.github.io/pr/1632/frontend (Takes 3-5 minutes after this completes to be available) [Sat Mar 9 21:47:37 UTC 2024] - Deleted deployment |
|
Why was the outer card removed for teammates? The floating effect looks nice/new on desktop, but it makes the UI really hard to parse on mobile |
Because there are now 4 characters in a 5 column layout, I thought the character card was using up too much padding. There is not much we can do with mobile other than creating separate UI just for mobile, which is something I don't really want to undertake until the UI around this area hits maturity (don't want to spend time on mobile layout optimization when we havent finalized the desktop UI) |
|
Also I really dislike the tall Add Character button. Can we make it a fixed height instead of 100% height |
Agreed |
* Condense characters page (#1621) * fix null checks (#1624) * Cache more actions (#1622) * cache more * Add comment * Speed up builds (#1626) * drop unnecessary deps * remove almost all build steps why doesnt json have trailing commas :( * rm build steps from sr * make equipped build title button-like (#1629) * make equipped build title button-like * format * make build TC title more button-like * only deploy if build was a success (#1633) * Create PRs in `new-release.yml` (#1631) * yep * fixes * allow squash merges * fix typo * typo2 * printf * Convert Pagination to infinite scroll (#1627) * Infinite scroll experiment on artifacts page * convert all pagination to infinite scroll * add inf scroll to art exclusion * fix typecheck in mini-ci (#1636) * fix typecheck in mini-ci * typecheck first * move teambuff to team overview (#1632) * move teambuff to team overview * update team button to settings icon * non full-width add button * Add teams page filter (#1639) * Add teams page filter * format * additional features * fix translation * Add `teams` tab to mobile UI (#1654) * Update teamcard (#1653) * update teamcard * remove unnecessary divider * more colorful teammate selector * update migration naming (#1658) * update migration naming * add migration for GO migration on import * Open Team Editor after creating team from character editor (#1655) * Open Team Editor after creating team from character editor * remove console.log * Show loadout + build name on teamcard hover (#1656) * show loadout + build name on teamcard hover * update teamcard * fix team navigation (#1659) * Combine Loadout and Build settings into a singular popup (#1662) * fix SetEffectDisplay * fix build --------- Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com> Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
* Condense characters page (#1621) * fix null checks (#1624) * Cache more actions (#1622) * cache more * Add comment * Speed up builds (#1626) * drop unnecessary deps * remove almost all build steps why doesnt json have trailing commas :( * rm build steps from sr * make equipped build title button-like (#1629) * make equipped build title button-like * format * make build TC title more button-like * only deploy if build was a success (#1633) * Create PRs in `new-release.yml` (#1631) * yep * fixes * allow squash merges * fix typo * typo2 * printf * Convert Pagination to infinite scroll (#1627) * Infinite scroll experiment on artifacts page * convert all pagination to infinite scroll * add inf scroll to art exclusion * fix typecheck in mini-ci (#1636) * fix typecheck in mini-ci * typecheck first * move teambuff to team overview (#1632) * move teambuff to team overview * update team button to settings icon * non full-width add button * Add teams page filter (#1639) * Add teams page filter * format * additional features * fix translation * Add `teams` tab to mobile UI (#1654) * Update teamcard (#1653) * update teamcard * remove unnecessary divider * more colorful teammate selector * update migration naming (#1658) * update migration naming * add migration for GO migration on import * Open Team Editor after creating team from character editor (#1655) * Open Team Editor after creating team from character editor * remove console.log * Show loadout + build name on teamcard hover (#1656) * show loadout + build name on teamcard hover * update teamcard * fix team navigation (#1659) * Combine Loadout and Build settings into a singular popup (#1662) * fix SetEffectDisplay * fix build --------- Co-authored-by: frzyc <frzyc@users.noreply.github.com> Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com> Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
This reverts commit ad657d4.
Describe your changes
Move the content of the teambuff tab to the team setting modal, which now serves as a "team overview"
Since this is the entry point towards engaging with the teams section, users are aware of teambuffs that interact with loadouts, and at a glance, users can also get a general idea if their loadouts are correct.
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.