Show loadout + build name on teamcard hover #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzyc
changed the title
|
[frontend] [Mon Mar 11 08:05:09 UTC 2024] - Deployed c9c3474 to https://genshin-optimizer-prs.github.io/pr/1656/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Mar 11 22:27:10 UTC 2024] - Deployed 7960201 to https://genshin-optimizer-prs.github.io/pr/1656/frontend (Takes 3-5 minutes after this completes to be available) [Mon Mar 11 22:35:03 UTC 2024] - Deleted deployment |
|
Is # of builds needed here? it feels a bit noisy |
|
I also think the badge wrapping is noisy and doesn't add much |
nguyentvan7
approved these changes
Mar 11, 2024
nguyentvan7
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Condense characters page (#1621) * fix null checks (#1624) * Cache more actions (#1622) * cache more * Add comment * Speed up builds (#1626) * drop unnecessary deps * remove almost all build steps why doesnt json have trailing commas :( * rm build steps from sr * make equipped build title button-like (#1629) * make equipped build title button-like * format * make build TC title more button-like * only deploy if build was a success (#1633) * Create PRs in `new-release.yml` (#1631) * yep * fixes * allow squash merges * fix typo * typo2 * printf * Convert Pagination to infinite scroll (#1627) * Infinite scroll experiment on artifacts page * convert all pagination to infinite scroll * add inf scroll to art exclusion * fix typecheck in mini-ci (#1636) * fix typecheck in mini-ci * typecheck first * move teambuff to team overview (#1632) * move teambuff to team overview * update team button to settings icon * non full-width add button * Add teams page filter (#1639) * Add teams page filter * format * additional features * fix translation * Add `teams` tab to mobile UI (#1654) * Update teamcard (#1653) * update teamcard * remove unnecessary divider * more colorful teammate selector * update migration naming (#1658) * update migration naming * add migration for GO migration on import * Open Team Editor after creating team from character editor (#1655) * Open Team Editor after creating team from character editor * remove console.log * Show loadout + build name on teamcard hover (#1656) * show loadout + build name on teamcard hover * update teamcard * fix team navigation (#1659) * Combine Loadout and Build settings into a singular popup (#1662) * fix SetEffectDisplay * fix build --------- Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com> Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
nguyentvan7
added a commit
that referenced
this pull request
Mar 12, 2024
* Condense characters page (#1621) * fix null checks (#1624) * Cache more actions (#1622) * cache more * Add comment * Speed up builds (#1626) * drop unnecessary deps * remove almost all build steps why doesnt json have trailing commas :( * rm build steps from sr * make equipped build title button-like (#1629) * make equipped build title button-like * format * make build TC title more button-like * only deploy if build was a success (#1633) * Create PRs in `new-release.yml` (#1631) * yep * fixes * allow squash merges * fix typo * typo2 * printf * Convert Pagination to infinite scroll (#1627) * Infinite scroll experiment on artifacts page * convert all pagination to infinite scroll * add inf scroll to art exclusion * fix typecheck in mini-ci (#1636) * fix typecheck in mini-ci * typecheck first * move teambuff to team overview (#1632) * move teambuff to team overview * update team button to settings icon * non full-width add button * Add teams page filter (#1639) * Add teams page filter * format * additional features * fix translation * Add `teams` tab to mobile UI (#1654) * Update teamcard (#1653) * update teamcard * remove unnecessary divider * more colorful teammate selector * update migration naming (#1658) * update migration naming * add migration for GO migration on import * Open Team Editor after creating team from character editor (#1655) * Open Team Editor after creating team from character editor * remove console.log * Show loadout + build name on teamcard hover (#1656) * show loadout + build name on teamcard hover * update teamcard * fix team navigation (#1659) * Combine Loadout and Build settings into a singular popup (#1662) * fix SetEffectDisplay * fix build --------- Co-authored-by: frzyc <frzyc@users.noreply.github.com> Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com> Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>
RobberToe
added a commit
to RobberToe/genshin-optimizer
that referenced
this pull request
Mar 13, 2024
This reverts commit 6ed2db7.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Old behaviour: shows character with currently equipped build, not the build used in the loadout
Update the loadout + build information to the hover information
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.