Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frzyc/go/simplify opt #1666

Merged
merged 21 commits into from
Mar 12, 2024
Merged

Frzyc/go/simplify opt #1666

merged 21 commits into from
Mar 12, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Mar 12, 2024

Describe your changes

Merge master, fix SetEffectDisplay

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

frzyc and others added 20 commits March 5, 2024 16:03
* cache more

* Add comment
* drop unnecessary deps

* remove almost all build steps

why doesnt json have trailing commas :(

* rm build steps from sr
* make equipped build title button-like

* format

* make build TC title more button-like
* yep

* fixes

* allow squash merges

* fix typo

* typo2

* printf
* Infinite scroll experiment on artifacts page

* convert all pagination to infinite scroll

* add inf scroll to art exclusion
* fix typecheck in mini-ci

* typecheck first
* move teambuff to team overview

* update team button to settings icon

* non full-width add button
* Add teams page filter

* format

* additional features

* fix translation
* update teamcard

* remove unnecessary divider

* more colorful teammate selector
* update migration naming

* add migration for GO migration on import
* Open Team Editor after creating team from character editor

* remove console.log
* show loadout + build name on teamcard hover

* update teamcard
@frzyc frzyc requested a review from nguyentvan7 March 12, 2024 07:02
@frzyc frzyc self-assigned this Mar 12, 2024
Copy link
Contributor

github-actions bot commented Mar 12, 2024

[sr-frontend] [Tue Mar 12 07:05:33 UTC 2024] - Deployed e623127 to https://genshin-optimizer-prs.github.io/pr/1666/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Mar 12 07:12:50 UTC 2024] - Deployed 64384c1 to https://genshin-optimizer-prs.github.io/pr/1666/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 07:13:39 UTC 2024] - Deployed 64384c1 to https://genshin-optimizer-prs.github.io/pr/1666/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Mar 12 20:00:05 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit ca73f9f into van/go/simplifyOpt Mar 12, 2024
2 checks passed
@nguyentvan7 nguyentvan7 deleted the frzyc/go/simplifyOpt branch March 12, 2024 19:59
nguyentvan7 added a commit that referenced this pull request Mar 12, 2024
nguyentvan7 added a commit that referenced this pull request Mar 12, 2024
@nguyentvan7 nguyentvan7 restored the frzyc/go/simplifyOpt branch March 12, 2024 20:00
@nguyentvan7 nguyentvan7 deleted the frzyc/go/simplifyOpt branch March 12, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants