Skip to content

Release 8.5.3 - fix coalesceLocales to handle undefined paths better #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

redbugz
Copy link

@redbugz redbugz commented Apr 19, 2024

When searching for locale files, some glob searches return undefined paths which end up breaking some of the logic. This fixes that by skipping undefined paths.

The Error that would show up:

The "path" argument must be of type string. Received undefined

This only happens when certain combinations of dependencies result in npm leaving those dependencies in node_modules under the parent instead of hoisting to the root.

After triaging the cause of the error and trying to avoid getting the undefined paths, that was trickier to get right as it depends on third party behavior, and it seemed easier to just allow the undefined paths through, but skip them once we try to inspect them.

@redbugz redbugz requested a review from a team April 19, 2024 14:25
@joeycozza joeycozza merged commit f9846b8 into frontierMaster Apr 19, 2024
@joeycozza joeycozza deleted the fix-path-error branch April 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants