Add FavourAsKeyword rule #709
Conversation
|
Thanks for your contribution! I'm going to do a quick review, but by the looks of it, most things are just going to be nitpicks; except one: please don't forget do add the new rule config entry in fsharplint.json: https://github.com/fsprojects/FSharpLint/blob/master/src/FSharpLint.Core/fsharplint.json |
| """ | ||
|
|
||
| Assert.AreEqual(expected, this.ApplyQuickFix source) | ||
| this.AssertErrorWithMessageExists("Prefer using the as pattern to match a constant and bind it to a variable.") |
There was a problem hiding this comment.
@ribeirotomas1904 let's rather have two tests: one for the AssertErrorWithMessageExists and another one for the QuickFix
There was a problem hiding this comment.
done in 573f0e0
src/FSharpLint.Core/Text.resx
Outdated
| </data> | ||
| </data> | ||
| <data name="RulesFavourAsKeyword" xml:space="preserve"> | ||
| <value>Prefer using the as pattern to match a constant and bind it to a variable.</value> |
There was a problem hiding this comment.
@ribeirotomas1904 nit, let's wrap the word "as" with single-quotes, to make this more readable (otherwise at first glance it's hard to see that as is meant to be read as a keyword)
There was a problem hiding this comment.
done in c985a31
Thanks for the feedback! config entry for the new rule added in 2f80c7e |
Add FavourAsKeyword rule and tests and docs for it.
Fixes #664