Lowercase package names in package cache (resolves #2676)

[julkwiec]

NuGet client used by dotnet CLI lowercases package names when saving them to packages folder and to the cache, while Paket doesn't touch the casing. On case-sensitive filesystems (i.e. on Mono under Linux) this causes dotnet restore to download the referenced packages again.

Repro steps (Windows + Docker)

1. Checkout https://github.com/julkwiec/paket-dotnet-docker-test
2. Open powershell, run run.ps1
3. In the container, run dotnet restore --source /empty - it will fail since the package source directory is empty and AutoMapper is not yet present in the cache.
4. Run mono paket.exe restore
5. Run dotnet restore --source /empty again - dotnet still doesn't find the package in cache
6. Lowercase the names of AutoMapper files and directories:

• cd ~/.nuget/packages
• mv AutoMapper automapper
• cd automapper/6.1.1/
• mv AutoMapper.6.1.1.nupkg automapper.6.1.1.nupkg
• mv AutoMapper.6.1.1.nupkg.sha512 automapper.6.1.1.nupkg.sha512
• mv AutoMapper.nuspec automapper.nuspec

7. Run cd /test
8. Run dotnet restore --source /empty. No failure this time - package was found in cache.

[julkwiec]

NuGet/Home#2522

[julkwiec]

Tested on Windows and Linux; looks like it works!

[forki]

the old nuget client didn't do it!? And I never saw that in the cache!?

[julkwiec]

What "old" NuGet client do you mean?

[forki]

Nuget.exe with packages.config Am 06.10.2017 09:44 schrieb "Julian Kwieciński" <notifications@github.com>:

…

What "old" NuGet client do you mean? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2812 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNC5klx7CEE1aFNuyihqWDH67V1Reks5spdpygaJpZM4PqWu6> .

[julkwiec]

I tested it using dotnet's built-in NuGet client, but afaik the standalone NuGet.exe lowercases package names as well. I'll check that in a moment.

[julkwiec]

Standalone nuget.exe 4.3.0 lowercases package names as well.
edit: same on NuGet 3.5.0

[forki]

weird. this just feels so wrong

[julkwiec]

it does, but afaik there's no other way to maintain cache compatibility 😢

[julkwiec]

Sorry, I screwed up the PR, I shouldn't have worked directly on master. New PR: #2826

[matthid]

weird. this just feels so wrong

@forki can you elaborate? Do you mean the concrete change or in general?

[forki]

in general.

[matthid]

Then I still don't get it. It is not our cache and we should do what nuget is doing? what is the problem?

[julkwiec]

I think it would be better to go along with NuGet's cache rules instead of using the same cache folder with different rules.

[forki]

yes I'm 100% your opinion to do it in same way as nguet. I just wonder why they changed it...

[julkwiec]

probably because they have to support Linux, which has case-sensitive filesystem.

On second thought... why did they decide to use lowercase instead of original casing everywhere?

[matthid]

@forki Are you sure that it was not me with the storage:none changes by accident?

[forki]

no I'm sure I saw "original casing" everywhere. that's why I was making so much efforts to get that right

[julkwiec]

relevant comment in NuGet repo: NuGet/Home#5637 (comment)

[forki]

That is not 100percent true. But anyway. Am 06.10.2017 15:34 schrieb "Julian Kwieciński" <notifications@github.com>:

…

relevant comment in NuGet repo: NuGet/Home#5637 (comment) <NuGet/Home#5637 (comment)> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2812 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNDgUydnKttLHaQ6ov6kKZ-NtVM3Nks5spix9gaJpZM4PqWu6> .