support for dotnet 8 #4219
Merged
support for dotnet 8 #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@forki I think this is ready, unless the remaining CI failures would be related to my changes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like dotnet 8, this is not ready, but it is cooking.
according to https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md older versions of windows are getting dropped, I'll need to adjust some of the tests I copy pasted.
I also believe we should consider a split "pre dotnet 5" and replace most of the stuff we keep duplicating, maybe by time of dotnet 10 would be a good time for this?