Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't visit operator in SynExpr.Quote, fixes 2535 #2560

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented Oct 6, 2022

fixes #2535

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


processSequence finalContinuation continuations (fun nodes ->
mkSynExprNode SynExpr_Quote synExpr range (sortChildren [| yield! nodes |]))
| SynExpr.Quote (_, _, quotedSynExpr, _, range) ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you only have one nested SynExpr it makes more sense to call visit directly.

@nojaf nojaf enabled auto-merge (squash) October 7, 2022 06:04
@nojaf nojaf merged commit 243dc23 into fsprojects:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect scope chosen for trivia, hence comments lost
2 participants