Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed comments on params with attributes #2588

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Fixed comments on params with attributes #2588

merged 3 commits into from
Oct 19, 2022

Conversation

stefan-schweiger
Copy link
Contributor

Fixes #2585

Added addtional cases for SynPat_Attrib, SynPat_Named, SynPat_Typed to visitLastChildNode

@stefan-schweiger stefan-schweiger changed the title 2585 attr param comment Fixed comments on params with attributes Oct 19, 2022
@nojaf
Copy link
Contributor

nojaf commented Oct 19, 2022

Hi Stefan, this looks good! Would you mind adding a CHANGELOG entry?

@stefan-schweiger
Copy link
Contributor Author

@nojaf Updated the changelog, let me know if there is anything else ;)

nojaf
nojaf approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

CHANGELOG.md
## [Unreleased]

### Fixed
* Comments get removed for method parameter with attribute [#2585](https://github.com/fsprojects/fantomas/issues/2585)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nitpick but all the other entries have . at end of the sentence before the [#.
No need to update it, just something I should add to the documentation.

@nojaf nojaf enabled auto-merge (squash) October 19, 2022 12:36
@nojaf nojaf merged commit f071172 into fsprojects:main Oct 19, 2022
@stefan-schweiger
Copy link
Contributor Author

Perfect thanks! When do you think this will be released? This is currently the major bug which prevents us from switching to Fantomas 5

@nojaf
Copy link
Contributor

nojaf commented Oct 19, 2022

Oh, well that is a bit of a trickier situation.
The plan was to release v5.1 as beta somewhere near the end of the week.
Did you verify your code base against the v5 stable or the latest main?

@stefan-schweiger
Copy link
Contributor Author

Against 5.0.6, but I guess in the worst case we can live with using the beta

@nojaf
Copy link
Contributor

nojaf commented Oct 19, 2022

The beta is available: https://www.nuget.org/packages/fantomas/5.1.0-beta-001
Our policy is that we no longer change the style once we have labelled it beta.
In short, this version will be very close to what 5.1 stable will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments get removed for method parameter with attribute
2 participants
@stefan-schweiger @nojaf