Changed default printing of override members to override from member
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could it check that a member is in an interface implementation and use |
|
@auduchinok yep, was able to enhance Trivia collection to grab info from tokens to preserve "member" keyword. |
nojaf
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Hello @Szer ,
Many thanks for this pull request.
It is really satisfying to see that you took the time to think things through.
And made an implementation that fits in how Fantomas works today.
Everything is covered nicely with unit test and I have nothing but praise for this.
Cheers,
nojaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to #742
the only meaningfulchange is insrc/Fantomas/CodePrinter.fsfrom:
|> Option.defaultValue (!- "member ")to
|> Option.defaultValue (!- "override ")updated
also added tweaks to trivia collection from tokens
which is according to spec shouldn't break anything.
Now all dispatch slots emits with
overridewhich allows more code to be generated from pure AST (check issue for more info)This PR doesn't change the behavior of AST formatting when Trivia (origin source code) is presented.
UPDATED
Enhanced trivia collection from tokens so now we could preserve
memberkeyword from sources.