Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit long function definitions #947

Merged
merged 8 commits into from
Jul 11, 2020
Merged

Revisit long function definitions #947

merged 8 commits into from
Jul 11, 2020

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 3, 2020

Adding support for both the Microsoft and G-Research style of formatting long function signatures.
Fixes #946

@nojaf nojaf requested a review from jindraivanek July 10, 2020 08:06
Smaug123
Smaug123 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@Smaug123 Smaug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! (Though I'm still not very familiar with Fantomas's internals, so probably don't take my word as gospel)

@knocte
Copy link
Contributor

knocte commented Jul 11, 2020

LGTM

@nojaf
Copy link
Contributor Author

nojaf commented Jul 11, 2020

Thanks, I'm just going to wait for @jindraivanek to take a look at the implementation, as quite some code changes were made.

@nojaf nojaf merged commit cda1c47 into fsprojects:master Jul 11, 2020
@nojaf nojaf deleted the fix-946 branch July 11, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knocte knocte knocte left review comments

@jindraivanek jindraivanek jindraivanek approved these changes

@Smaug123 Smaug123 Smaug123 approved these changes

@JackMatusiewiczGR JackMatusiewiczGR Awaiting requested review from JackMatusiewiczGR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review long function definitions
4 participants
@nojaf @knocte @jindraivanek @Smaug123