Skip to content

bugfix: await on size, assuming it can be an async function #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bugfix: await on size, assuming it can be an async function #1281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b2bf0c
await on size, assuming it can be an async function
mukhery May 29, 2023
69dd8af
black
mukhery Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fsspec/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,11 @@ async def _cp_file(
if hasattr(fs2, "open_async")
else fs2.open(url2, "wb", **kw)
)
while f1.size is None or f2.tell() < f1.size:
while await maybe_await(f1.size) is None or f2.tell() < await maybe_await(
f1.size
):
data = await maybe_await(f1.read(blocksize))
if f1.size is None and not data:
if await maybe_await(f1.size) is None and not data:
break
await maybe_await(f2.write(data))
callback.absolute_update(f2.tell())
Expand Down