Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package and add write #2

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Make package and add write #2

merged 2 commits into from
Nov 5, 2019

Conversation

martindurant
Copy link
Member

No description provided.

Copy link
Collaborator

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin!

@martindurant
Copy link
Member Author

Interestingly, it turns out that it's totally valid to have files on gdrive with identical names. I suppose when trying to read, we should simply give the most recent one? Right now it will error when more than one entry matches anywhere up the path tree.

@rabernat
Copy link
Collaborator

rabernat commented Nov 1, 2019

Interestingly, it turns out that it's totally valid to have files on gdrive with identical names. I suppose when trying to read, we should simply give the most recent one? Right now it will error when more than one entry matches anywhere up the path tree.

Correct, this is what I learned. That's why I added this error:

https://github.com/rabernat/fsspec-google-drive/blob/341b8d66785abbfd288827d9cff8c0a6d12b10e1/gdrivefs.py#L168-L176

I also had to add some stuff to filter out trashed files by default.

Should I merge this?

@martindurant
Copy link
Member Author

Should I merge this?

Sure - it's not exactly released anywhere.
We should discuss that plan, though: would you like this moved to the intake org and a minimal working version prepared for pypi/conda, so we can get people to play with it? Perhaps that's too early, I have hardly put a lot of time into it, and probably neither of us has much to give.

@martindurant
Copy link
Member Author

By the way, there is an argument to be made that the default "root" shouldn't be (just) the user's default drive, but the set of shared drives available to the user, including their own drive. For some users that would be just the one thing, so add an extra directory-like layer.

@rabernat rabernat merged commit 09d5db9 into fsspec:master Nov 5, 2019
@rabernat rabernat mentioned this pull request Nov 5, 2019
@rabernat
Copy link
Collaborator

rabernat commented Nov 5, 2019

We should discuss that plan, though: would you like this moved to the intake org and a minimal working version prepared for pypi/conda, so we can get people to play with it?

Yes I think this is the best way forward.

I have added you as a collaborator. Happy to see repo transferred to intake org.

@martindurant
Copy link
Member Author

I would need to be an owner to transfer it.

@martindurant martindurant deleted the writing branch November 5, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants