This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ever just stick on article if it is present.
@@ -5,6 +5,7 @@ | |||
"babel-preset-es2015": "^6.3.13", | |||
"bluebird": "^3.0.5", | |||
"body-parser": "^1.14.1", | |||
"co": "^4.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using co because it is tiny and bluebird was breaking Promise, (was getting weird error Promise.all not defined!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does seem odd! Promise
in this version of Node has .all
method and bluebird itself ships with a .all
method :-/
This was referenced Feb 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds an article with an image about an organisation defined as a query param and prepends it to the top of the list.
The back end searches for a company matching the query param
It then gets the stories for this company and queries them against v1 api
until it is only finding old stories (1 day+) or it has found one already
This story then gets put at the top of the list