Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Mixin orgs #79

Merged
merged 16 commits into from
Feb 22, 2016
Merged

Mixin orgs #79

merged 16 commits into from
Feb 22, 2016

Conversation

AdaRoseCannon
Copy link
Contributor

Finds an article with an image about an organisation defined as a query param and prepends it to the top of the list.

The back end searches for a company matching the query param
It then gets the stories for this company and queries them against v1 api
until it is only finding old stories (1 day+) or it has found one already
This story then gets put at the top of the list

image

@@ -5,6 +5,7 @@
"babel-preset-es2015": "^6.3.13",
"bluebird": "^3.0.5",
"body-parser": "^1.14.1",
"co": "^4.6.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using co because it is tiny and bluebird was breaking Promise, (was getting weird error Promise.all not defined!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does seem odd! Promise in this version of Node has .all method and bluebird itself ships with a .all method :-/

JakeChampion added a commit that referenced this pull request Feb 22, 2016
@JakeChampion JakeChampion merged commit 2da2b10 into master Feb 22, 2016
@JakeChampion JakeChampion deleted the mixin-orgs branch February 22, 2016 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants